Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a publication/person relationship during submission, causes the relationship to be displayed twice #8584

Open
hutattedonmyarm opened this issue Nov 14, 2022 · 0 comments
Labels
bug component: configurable entities Related to Configurable Entities feature component: submission Related to configurable submission system help wanted Needs a volunteer to claim to move forward

Comments

@hutattedonmyarm
Copy link
Contributor

Describe the bug
DSpace Version: DSpace 7.4

This looks to be an edge case, with a specific submission configuration situation (detailed below).
When adding a new author via lookup, all authors (including the newly added one) show up duplicated. They are stored (correctly) only once. Reloading the submission page fixes the display, until a new author is added via lookup.

To Reproduce
Steps to reproduce the behavior:

  1. Enable entities, relevant are: person and publication
  2. In submission-forms.xml, add the dc.contributor.author field twice, with different type-bind settings (e.g. required for one type, not required for another) as mentioned in the documentation. They need to be configured as relationship fields between the person and publication entities
  3. Start a new submission for the publication entity
  4. Select a dc.type, so that the type binding fields are correctly displayed
  5. Open the relationship dialog for authors, using the lookup button
  6. Select a person entity, e.g. a local one

The relationship will be added to the metadata and listed twice in the submission form.
Reloading the submission form, fixes the issue.

Expected behavior
The relationship should be added to the metadata and listed once in the submission form

Notes
I took a look at the server responses for the workspace items. The correct metadata is visible in _embedded/item/metadata/dc.contributor.author, but /sections/publicationBasicdata/dc.contributor.author always contains each author twice, even after reloading:
image

This is caused by DescribeStep.java, in the readField(InProgressSubmission obj, SubmissionStepConfig config, DataDescribe data, DCInputSet inputConfig) method it iterates over the submission configuration, adding metadata for each field it encounters in the form. The offending field dc.contributor.author is encountered twice, so the metadata values are added twice

@hutattedonmyarm hutattedonmyarm added bug needs triage New issue needs triage and/or scheduling labels Nov 14, 2022
@tdonohue tdonohue added component: submission Related to configurable submission system performance / caching Related to performance or caching issues component: configurable entities Related to Configurable Entities feature help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling performance / caching Related to performance or caching issues labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: configurable entities Related to Configurable Entities feature component: submission Related to configurable submission system help wanted Needs a volunteer to claim to move forward
Projects
Status: 🙋 Needs Help / Unscheduled
Development

No branches or pull requests

2 participants