DS-1343 Add parent pom.xml and build.propertiesfiles into the binary release #112

Merged
merged 4 commits into from Oct 31, 2012

2 participants

@robintaylor
DSpace Repository member

Please don't be in a rush to merge, it needs some discussion first.

@tdonohue
DSpace Repository member

Taking a closer look at this now...

I believe I've just figured out a way to exclude all the testEnvironment stuff from the binary Release via a profile.

So, I'd suggest NOT merging this yet. Much of what Robin's done is correct & looks good, but I think with one more step we can actually avoid having all the testing framework files in the binary release after all.

@tdonohue
DSpace Repository member

As you can see in the "reference" above, I've just generated a new pull request that merges Robin's changes above, along with a few tweaks of mine which allow the testEnvironment stuff to be left out of the Binary Release.

So, I think this pull request can be closed & left unmerged, in favor of #119

@robintaylor robintaylor merged commit 2a03800 into DSpace:master Oct 31, 2012
@robintaylor robintaylor added a commit that referenced this pull request Oct 31, 2012
@robintaylor robintaylor Backout pull request #112 9205de1
@hardyoyo hardyoyo pushed a commit that referenced this pull request Nov 14, 2012
@robintaylor robintaylor Backout pull request #112 58ab482
@artlowel artlowel pushed a commit to atmire/DSpace that referenced this pull request Jun 13, 2014
@robintaylor robintaylor Backout pull request #112 2fe6720
@kosarko kosarko pushed a commit to kosarko/DSpace that referenced this pull request May 29, 2015
jm fixed #112 ff62131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment