Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

DS-1360 Porting advanced embargo function to JSPUI #116

Closed
wants to merge 13 commits into from

7 participants

@zuki
Owner

https://jira.duraspace.org/browse/DS-1360

This is a porting the advanced embargo function to JSPUI. I think it include all fuction to supoort the advanced embargo for JSPUI.

@lyncodev
Owner

Type Huge code contribution
Code review +1 this is nice! Good work!
Feature review Didn't test it

@helix84

This looks like a hybrid of BrowserServlet and WithdrawnBrowserServlet. Why was another class needed? Amend this JavaDoc.

Owner

I modeled it after XMLUI that has its WithdrawnItems and PrivateItems aspect in Administrative section.

@helix84

This is mostly a copy of JSPUploadStep. It would make sense to inherit from it.

Owner

I have edited the code to inherit from JSPUploadStep. In order to do it, I had to edit the code of JSPUploadStep too. Also I have edited the UploadWithEmbargoStep to inherit from UploadStep.

@helix84

Remove " (not supported in JSPUI)" :)

Owner

Removed this sentence.

@helix84
Owner

Closing this pull request because I rebased it and cleaned it up as #212

@helix84 helix84 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 30, 2012
  1. @zuki
Commits on Dec 13, 2012
  1. @pnbecker

    Declare method register(Context,DspaceObject, String) of

    pnbecker authored
    org.dspace.identifier.IdentifierProvider to throw an
    IdentifierException. Fixes DS-1424.
  2. @akonczak
  3. @aschweer

    DS-1426 Improve SolrLogger performance

    aschweer authored
    Apply the patch to the right file for master
    Fix whitespace issues
Commits on Dec 14, 2012
  1. @aschweer

    Merge pull request #157 from aschweer/solrlogger-improve-efficiency

    aschweer authored
    DS-1426 SolrLogger performance
  2. @KevinVdV

    Merge pull request #158 from aschweer/browse-sort-options

    KevinVdV authored
    DS-1427 Keep sort options in order
  3. @helix84

    Merge pull request #155 from tuub/master

    helix84 authored
    Fixes DS-1424
Commits on Dec 17, 2012
  1. @helix84

    Merge pull request #156 from akonczak/master

    helix84 authored
    DS-1425 - OAI - ORACLE DB
Commits on Dec 20, 2012
  1. @helix84
Commits on Jan 5, 2013
  1. @zuki

    adjast to fit my env

    zuki authored
  2. @zuki
  3. @zuki
Commits on Jan 6, 2013
  1. @zuki
Something went wrong with that request. Please try again.