DS-1360 Porting advanced embargo function to JSPUI #116

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
7 participants
Owner

zuki commented Oct 30, 2012

https://jira.duraspace.org/browse/DS-1360

This is a porting the advanced embargo function to JSPUI. I think it include all fuction to supoort the advanced embargo for JSPUI.

Owner

lyncodev commented Dec 7, 2012

Type Huge code contribution
Code review +1 this is nice! Good work!
Feature review Didn't test it

This looks like a hybrid of BrowserServlet and WithdrawnBrowserServlet. Why was another class needed? Amend this JavaDoc.

Owner

zuki replied Jan 6, 2013

I modeled it after XMLUI that has its WithdrawnItems and PrivateItems aspect in Administrative section.

This is mostly a copy of JSPUploadStep. It would make sense to inherit from it.

Owner

zuki replied Jan 6, 2013

I have edited the code to inherit from JSPUploadStep. In order to do it, I had to edit the code of JSPUploadStep too. Also I have edited the UploadWithEmbargoStep to inherit from UploadStep.

Remove " (not supported in JSPUI)" :)

Owner

zuki replied Jan 6, 2013

Removed this sentence.

Owner

helix84 commented May 8, 2013

Closing this pull request because I rebased it and cleaned it up as #212

helix84 closed this May 8, 2013

@kosarko kosarko pushed a commit to kosarko/DSpace that referenced this pull request May 29, 2015

@vidiecan vidiecan Merge pull request #116 from ufal/issue_115
old_value can possibly be null
d6bf688

@alanorth alanorth added a commit to alanorth/DSpace that referenced this pull request Jul 11, 2015

@alanorth alanorth Merge pull request #116 from alanorth/4_x-facet-limits
discovery.xml: Adjust sidebar facet limits
2cc7197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment