Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL link to the bitstream content renamed #1809

Merged
merged 6 commits into from Sep 25, 2017
Merged

Conversation

abollini
Copy link
Member

This PR remove the link "retrieve" from the bitstream resource in favor of "content" to keep the HAL link name aligned with the endpoint path.
It should be not merged before than the corresponding angular issue (DSpace/dspace-angular#125 ) has been solved and the new code deployed on the demo angular ui site.

Please note that the angular ui site can be updated before to apply this PR to the rest demo site as the current code support access to the bitstream content using both link names (retrieve and content)

…ocument

This is an initial draft that require further refinements. By default now all the collection properties
are embedded in response, linked entities listed in the LinksRest annotation of the repository are
included only if specified in the resource wrapper instantiation and supported for embedding by
the link repository (i.e the relation have suitable default or don't depend on additional parameters)
Keep in place also the old link name retrieve to be backward compatible
@abollini abollini added the interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module) label Jul 14, 2017
@abollini abollini added this to the 7.0 milestone Jul 14, 2017
@abollini
Copy link
Member Author

This PR can be merged as the corresponding angular PR has been already approved & merged see DSpace/dspace-angular#131

@abollini abollini merged commit 83446ab into master Sep 25, 2017
@abollini abollini deleted the bitstream-retrieve-renamed branch September 25, 2017 08:26
@tdonohue tdonohue modified the milestones: 7.0, 7.0preview Jan 26, 2021
Atmire-github pushed a commit to atmire/DSpace that referenced this pull request Jan 12, 2023
Atmire-github pushed a commit to atmire/DSpace that referenced this pull request Jan 12, 2023
Atmire-github pushed a commit to atmire/DSpace that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants