Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[DS-3967] 6x - Migrate Dockerfile to DSpace/DSpace #2134
The local.cfg / build.properties can be gerated at build time as shown here: https://github.com/ppmdo/dspace-docker/blob/93bb794e97b9fa90ed00981721b3de809f1cf5f5/Dockerfile#L52
Although I think that approach can get quite complicated if the dspace.cfg requires many modifications.
Also, It could be useful to build with Mirage2 included and the let the user select the desired theme using an ENV variable as shown here: https://github.com/ppmdo/dspace-docker/blob/93bb794e97b9fa90ed00981721b3de809f1cf5f5/Dockerfile#L63
@ppmdo , thanks for the comments. I had not thought about Mirage2 support.
I am going to test building the images with Mirage2 enabled by default. It will slow the build down a bit, but it should give the end user more flexibility with theme selection. I will share my progress on this.
I envision that the user will use a volume mount in the docker compose file to override any additional properties at runtime (local.cfg, xmlui.xconf). My hope is to minimize the number of variant Docker images that the project will support.
Now that the Dockerfile will exist on each supported branch of DSpace, I have customized the Dockerfiles to provide a minimal local.cfg or build.properties file within each branch. If you take a look at the related PR's you will see that I am providing the files to be overridden.
Tested in Windows 10 with the following docker-compose file: https://github.com/DSpace-Labs/DSpace-Docker-Images/pull/51/files#diff-e437aab83f63209d609c14191f498e5e
Works without problems, with and without the Mirage2 option.