Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the CRUD operations on the Collection and Community… #2277
Added support for the CRUD operations on the Collection and Community… #2277
Changes from 6 commits
d77dd7f
e283f43
fb1a8b8
b96cf91
3d011c5
0f6148d
2db2b70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check for ADD on the parent community instead than general admin rights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we need to log a bug ticket to refactor
createAndReturn()
.As
createAndReturn
only takes in a Context object, I'm not sure it can use the more appropriate@PreAuthorize("hasPermission(#id, 'COMMUNITY', 'ADD')")
annotation...because it doesn't have a place to grab the parent Community ID from.So, while I agree with @abollini, I think this particular line needs to stay as-is, until we can refactor
createAndReturn
to allow for fine grained permission checks (I'll create a ticket for it)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logged as a bug here: https://jira.duraspace.org/browse/DS-4153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check for ADD on the parent instead than general admin rights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I noted for CollectionRestRepository, I don't think we can fix this line until
createAndReturn()
is refactored to work better with Spring Security annotations.