Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DS-824 Request copy of item for XMLUI #260

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
4 participants

muelle commented Jul 22, 2013

https://jira.duraspace.org/browse/DS-824

Request a copy of a protected item for XMLUI. A reimplementation of JSPUI version of the Universidade do Minho at www.uminho.pt.

Note.- This need a new table in the database to work.

Owner

bram-atmire commented Jul 22, 2013

Hi,

this looks like great work, Request a copy is definitely a much needed feature in XMLUI.
I very much like how you have put email messages as part of the XMLUI messages catalog.

Why are you not taking the same approach using JSP?

In another effort, we're trying to bring the JSP email templates into the messages as well:
https://jira.duraspace.org/browse/DS-1589

Bram

Owner

helix84 commented Jul 22, 2013

The SQL in database_schema-requestitem.sql should be in database_schema_3-4.sql instead. Also in database_schema.sql.

This should go to update-sequences.sql:
SELECT setval('requestitem_seq', max(requestitem_id)) FROM requestitem;

You can modify this PR by adding another commit to your source branch (muelle:request-copy).

muelle commented Jul 25, 2013

Hi Bram
First of all Sorry about my english.
Is a pity that the two lines of user interface, jspui and xmlui, they are at different levels of development, but currently we are only developing for xmlui.
Thanks for your interest.
Adan

Owner

helix84 commented Jul 25, 2013

Hi Muelle, just a detail - our autobuilder ran the license header check and found that the license header is not literally what it should be in the new files. You should probably split the license and autorship comments into two separate comments. The later one is usualy below the imports (in the JavaDoc class comment). Sorry about the nitpicking.

It concerns these files:
https://travis-ci.org/DSpace/DSpace/builds/9462568#L3667

You can run the license check this way:
mvn package license:check

Owner

helix84 commented Jul 25, 2013

More nitpicking - sorry. The convention for file names in [dspace]/config/emails/ seems to be lowercase and underscore as a separator. As Bram noted above, we'll hopefully get rid of these files soon, but if you're using them, please be consistent.

Owner

abollini commented Oct 11, 2013

this pull request need to be rebased to solve merge conflict

@helix84 helix84 closed this Oct 20, 2013

Owner

helix84 commented Oct 20, 2013

I rebased this and submitted a as a new PR #338.

@alanorth alanorth added a commit to alanorth/DSpace that referenced this pull request Aug 5, 2016

@alanorth alanorth Merge pull request #260 from alanorth/5_x-item-display-species
Fix display of Species in item display
ec64b58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment