Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[DS-1848] OAI harvest issues when starting from control panel/command line #433

Merged
merged 2 commits into from Feb 18, 2014

Conversation

Projects
None yet
4 participants
Owner

bram-atmire commented Dec 21, 2013

Testing this, I am getting warnings like:

2013-12-21 11:20:10,128 WARN org.dspace.core.Context @ bram@atmire.com:session_id=ECEA0AA81DDBE4620DAE6822CCAE1014:ip_addr=0:0:0:0:0:0:0:1%0:restore_auth_sys_state:not previous state info available null

to put this in a larger context, here's the surrounding log output, right at the end of the harvest:

2013-12-21 11:24:46,740 INFO org.dspace.content.Collection @ bram@atmire.com:session_id=ECEA0AA81DDBE4620DAE6822CCAE1014:ip_addr=0:0:0:0:0:0:0:1%0:update_collection:collection_id=6
2013-12-21 11:24:46,741 WARN org.dspace.core.Context @ bram@atmire.com:session_id=ECEA0AA81DDBE4620DAE6822CCAE1014:ip_addr=0:0:0:0:0:0:0:1%0:restore_auth_sys_state:not previous state info available null
2013-12-21 11:24:46,741 INFO org.dspace.harvest.OAIHarvester @ Harvest from https://smartech.gatech.edu/oai/request successful. The process took 227503 milliseconds.

Is this because the restorestate is called twice?

Owner

tdonohue commented Jan 29, 2014

Any updates on this PR? We're starting to review PRs/Fixes for possible inclusion into a 4.1 release. This looks like it's "mostly ready". But, as Bram points out, there's two restoreAuthSystemState() calls in a row.

Owner

KevinVdV commented Jan 30, 2014

I added a more elegant approach to fix this issue. By adding a try finally around the part of the code that "might" crash and adding a restoreAuth here will ensure the removal of these logs.

Owner

bram-atmire commented Jan 30, 2014

Didn't test explicitly but +1 by looking at the code. Can be merged as far as i'm concerned.

Owner

helix84 commented Jan 30, 2014

Just to be clear - this PR fixes both DS-1834 and DS-1848, right?

Owner

KevinVdV commented Jan 30, 2014

The test appears to fail in the services:

Failed tests:
testGetCaches(org.dspace.services.caching.CachingServiceTest)

Although my change doesn't make any alterations to the services framework.
Anybody got any idea ?

Owner

helix84 commented Jan 30, 2014

Don't worry about it, your change doesn't cause the test failure: https://jira.duraspace.org/browse/DS-1895

helix84 added a commit that referenced this pull request Feb 18, 2014

Merge pull request #433 from KevinVdV/DS-1848
[DS-1848] OAI harvest issues when starting from control panel/command line

@helix84 helix84 merged commit 95ff5c7 into DSpace:master Feb 18, 2014

1 check failed

default The Travis CI build failed
Details

artlowel pushed a commit to atmire/DSpace that referenced this pull request Jun 13, 2014

Merge pull request #433 from KevinVdV/DS-1848
[DS-1848] OAI harvest issues when starting from control panel/command line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment