New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS-1226] Batch import from major bibliographic formats #46
Conversation
Hi all, this would be a great contribution, just a few observations for anyone else reviewing the code based on a very quick initial look...
Cheers, Robin. |
Just another wee observation, looking into the biblio-transformation-engine.jar I notice that the pom has a number of dependencies so of which contain variables eg... uk.ac.shef.wit simmetrics 1.0 system ${basedir}/lib/simmetrics_v1_6_2_ekt.jarCan these be removed ? Cheers. |
Doh ! The XML notation is not apparent in that last comment. Imagine those are the values in a typical maven dependency. |
Found the source code for the biblio-transformation-engine.jar. Should have read the Jira record first :) |
Copied from Jira issue... Hi Kostas, I am having a bit of trouble testing this. The error I am getting is ... java.lang.NoClassDefFoundError: gr/ekt/transformationengine/exceptions/UnknownClassifierException If I understand correctly then the script 'dspace' uses dspace/lib as its classpath, but the new jars are not in dspace/lib. Have I misunderstood something ? Thanks, Robin. |
Copied from Jira issue... @robintaylor @robintaylor @kstamatis |
Dear Robin, regarding your comment above for the dependencies of the biblio-transformation-engine the answer is yes, the simmetric library can be removed with no other side-effects. There is also a second dependency that contains variables, the jbibtex jar, but this cannot be removed if we want to support the batch import from a BibTex file. However, I guess, this jar can be hosted in some Maven repo, or not? Thanks a lot for your time and interest in this dspace contribution |
Hi Robin, just to add a comment for anyone else reviewing the code, regarding part 3 of your initial comment. The configuration files (spring-based xml config files) that affect the operation of the biblio-transformation-engine are located in the config folder of the DSpace project and not in the biblio-transformation-engine jar file. Within these files, someone can define the mapping from the input format to the DC metadata schema of DSpace (even if the latter is a non-standard DC schema). Thanks a lot! |
please check the comment on the jira issue: |
Dear Mark, Thank you for your comments (that now are lost - I am sorry, after the new squashing I did, I deleted the old branch which seems removed your comments). Regarding you comment in yesterday's DevMtg: [20:22] I am happy to see the servicemanager support. I'm still seeing use of package names that are not org.dspace I cannot see any packages named "gr.ekt" since, for this extension we didn't write our own classes, just added code in the ItemImport.java class DSpace already had. Please, verify that this is true. Thus, after the new commit, I also fetched the new version from DSpace master, so no conflicts will appear when merging this contribution. Thanks a lot, Kostas |
[DS-1226] Batch import from major bibliographic formats
[DS-1226] Batch import from major bibliographic formats
Addresses #46. Signed-off-by: Alan Orth <a.orth@cgiar.org>
Addresses #46. Signed-off-by: Alan Orth <a.orth@cgiar.org>
Addresses #46. Still to figure out which strings we need to print as "subject" and which we need to print as "subjects". From looking at the XMLUI string names it's not exactly obvious where they will be used, so it makes it hard to judge what context they will be printed in! Signed-off-by: Alan Orth <a.orth@cgiar.org>
Addresses #46. Signed-off-by: Alan Orth <a.orth@cgiar.org>
…e-autowarming re DSpace#1501 set autowarmingCount=100 for the search Solr core
* [VSIM-79] updated Maven overrides for handlebars templates with versions from upstream Mirage2 * [VSIM-79] Wait! Don't override things you haven't changed, that's not how this works!
* [VSIM-79] updated Maven overrides for handlebars templates with versions from upstream Mirage2 * [VSIM-79] Wait! Don't override things you haven't changed, that's not how this works!
* [VSIM-79] updated Maven overrides for handlebars templates with versions from upstream Mirage2 * [VSIM-79] Wait! Don't override things you haven't changed, that's not how this works!
EKT's extension to DSpace to support batch import from major bibliographic formats
https://jira.duraspace.org/browse/DS-1226