[DS-1898] OAI not always closing contexts #462

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@KevinVdV
Owner

KevinVdV commented Jan 31, 2014

Added a finally with a context.abort(), this way the context will always be closed.

@lyncodev lyncodev referenced this pull request Jan 31, 2014

Closed

DS-1649: OAI 2.1 #441

@lyncodev

This comment has been minimized.

Show comment Hide comment
@lyncodev

lyncodev Jan 31, 2014

Owner

Hi,

as part of #441 I will create a new pull request and also fix this issue.
If merged, this pull will again conflict with the set of changes in #441.

Basically, if we are willing to merge the set of changes in #441 we should consider droping this pull request.

Anyway, I think this fix should go to the 4.x branch too.

Owner

lyncodev commented Jan 31, 2014

Hi,

as part of #441 I will create a new pull request and also fix this issue.
If merged, this pull will again conflict with the set of changes in #441.

Basically, if we are willing to merge the set of changes in #441 we should consider droping this pull request.

Anyway, I think this fix should go to the 4.x branch too.

@tdonohue

This comment has been minimized.

Show comment Hide comment
@tdonohue

tdonohue Jan 31, 2014

Owner

Hi @lyncodev ,

The set of changes in #441 could be merged into "master" (for 5.0). However, #441 changes should not be merged into the 4.1 release, as you've included several new features (and made some larger scale changes that look like they would not qualify for 4.1). Remember, 4.1 is a "bug-fix-only" release.

Therefore, at a minimum, we'd want this particular bug (#462) fixed for 4.1. But, if you wanted to also backport other bug-fixes to 4.1, that'd be great too.

Owner

tdonohue commented Jan 31, 2014

Hi @lyncodev ,

The set of changes in #441 could be merged into "master" (for 5.0). However, #441 changes should not be merged into the 4.1 release, as you've included several new features (and made some larger scale changes that look like they would not qualify for 4.1). Remember, 4.1 is a "bug-fix-only" release.

Therefore, at a minimum, we'd want this particular bug (#462) fixed for 4.1. But, if you wanted to also backport other bug-fixes to 4.1, that'd be great too.

@lyncodev

This comment has been minimized.

Show comment Hide comment
@lyncodev

lyncodev Jan 31, 2014

Owner

Hi Tim,

That's what I was thinking. Just commented because this pull is against the master branch.

Owner

lyncodev commented Jan 31, 2014

Hi Tim,

That's what I was thinking. Just commented because this pull is against the master branch.

@helix84

This comment has been minimized.

Show comment Hide comment
@helix84

helix84 Feb 14, 2014

Owner

Closing this PR. I cherry-picked the commit it contains to dspace-4_x and dspace-3_x.
61255bf
4b4e65c

For master, this should be addressed by #466, which is also merged now.

Owner

helix84 commented Feb 14, 2014

Closing this PR. I cherry-picked the commit it contains to dspace-4_x and dspace-3_x.
61255bf
4b4e65c

For master, this should be addressed by #466, which is also merged now.

@helix84 helix84 closed this Feb 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment