Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[IN-PROCESS] [DS-1144] Maven Project Consolidation #5
Sorry for delayed response.
Honestly, I'd be +1 this change. It's a major re-working of the Maven projects (which could cause some pain for folks upgrading to 3.0 -- but only for those not using 'module' Overlays). But, in my opinion, it's a simplification of our codebase. I've always disliked all the "-api" and "-webapp" subprojects.
I'd say the best way forward is to get a vote in front of the Committers/Developers. Maybe we do this on dspace-devel? Or schedule this for an IRC meeting right after OR12? (Or you could bring it up at OR12 Dev Mtg during the 3.0 session).
For others who may be "intimidated" by the large number of commits/changes in this Pull Request, you can more easily see the new Maven folder structure by just looking at Mark's 'maven-project-consolidation' branch:
As you'll immediately notice, gone are all the "-api" and "-webapp" submodules for every Web App. Instead, it's a much more simplified codebase, with less Maven projects.
My current thought is that we could hold off on the consolidation until after the feature freeze date or just before the release, this way it will not impact those working on contribution right now. (IMO, I feel the same way about the DAO work) as these are both going to touch a lot of code, I think its important that we organize these to happen at the end.