Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IN-PROCESS] [DS-1144] Maven Project Consolidation #5

Closed
wants to merge 24 commits into from

Conversation

Projects
None yet
3 participants
@mdiggory
Copy link
Member

commented Apr 21, 2012

Pull request to move the maven project consolidation into place in master.

mdiggory added some commits Mar 31, 2012

@mdiggory mdiggory closed this Apr 23, 2012

@mdiggory mdiggory reopened this Apr 23, 2012

@mdiggory

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2012

Come on folks... How about a little review... This is an example of if you leaving Pull requests floating too long. Now theres more work to do to get this back onto the master.

@tdonohue

This comment has been minimized.

Copy link
Member

commented Jun 29, 2012

Sorry for delayed response.

Honestly, I'd be +1 this change. It's a major re-working of the Maven projects (which could cause some pain for folks upgrading to 3.0 -- but only for those not using 'module' Overlays). But, in my opinion, it's a simplification of our codebase. I've always disliked all the "-api" and "-webapp" subprojects.

I'd say the best way forward is to get a vote in front of the Committers/Developers. Maybe we do this on dspace-devel? Or schedule this for an IRC meeting right after OR12? (Or you could bring it up at OR12 Dev Mtg during the 3.0 session).

For others who may be "intimidated" by the large number of commits/changes in this Pull Request, you can more easily see the new Maven folder structure by just looking at Mark's 'maven-project-consolidation' branch:
https://github.com/mdiggory/DSpace/tree/maven-project-consolidation/

As you'll immediately notice, gone are all the "-api" and "-webapp" submodules for every Web App. Instead, it's a much more simplified codebase, with less Maven projects.

More details at: https://wiki.duraspace.org/display/DSPACE/Maven+Project+Consolidation

@mdiggory

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2012

Thanks Tim,

My current thought is that we could hold off on the consolidation until after the feature freeze date or just before the release, this way it will not impact those working on contribution right now. (IMO, I feel the same way about the DAO work) as these are both going to touch a lot of code, I think its important that we organize these to happen at the end.

@ottenhoff

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2012

Simplified projects mean lower barrier to entry for new devs. This consolidation makes a lot of sense to me and even though would require a bit of reworking of any customizations I track locally, it's still a +1 to help new devs

mwoodiupui referenced this pull request in mwoodiupui/DSpace Sep 18, 2012

Merge pull request #5 from mwoodiupui/DSRV-22
[DSRV-22] Detect indirect circular property references

@mdiggory mdiggory closed this Oct 3, 2012

lap82 pushed a commit to lap82/DSpace that referenced this pull request Jul 24, 2013

Andrea
Merge pull request DSpace#5 from lap82/P2CRIS-217
Fix authority management for metadata build with item enhancer

lap82 pushed a commit to lap82/DSpace that referenced this pull request Oct 19, 2013

Merge pull request DSpace#5 from lap82/DS-1252-bte
Add UI support for the upload file in submission lookup

arieljlira referenced this pull request in sedici/DSpace Jun 9, 2014

artlowel referenced this pull request in atmire/DSpace Jun 13, 2014

Merge pull request #5 from mwoodiupui/DSRV-22
[DSRV-22] Detect indirect circular property references

artlowel referenced this pull request in atmire/DSpace Jun 13, 2014

Merge pull request #5 from lap82/DS-1252-bte
Add UI support for the upload file in submission lookup

hardyoyo pushed a commit to hardyoyo/DSpace that referenced this pull request Dec 10, 2014

Hardy Pottinger
Merge pull request DSpace#5 from hardyoyo/lso-1317-fix-assetstore
fixing assetstore properties in build.properties and dspace.cfg

mwoodiupui added a commit that referenced this pull request Jan 7, 2015

Merge pull request #5 from hardyoyo/add-launcher-to-803
added a launcher configuration for the multi-format date parser

tdonohue added a commit that referenced this pull request Oct 13, 2015

Merge pull request #5 from helix84/DS-2777-fix-oai-2
fix "QuerySyntaxException: metadatavalue is not mapped"

KevinVdV added a commit that referenced this pull request Oct 29, 2015

tomdesair referenced this pull request in tomdesair/DSpace Apr 21, 2016

Merge pull request atmire#5 from tomdesair/DS-3086-OAI-FIX
DS-3086: Fixed bug that made the integration tests fail

hardyoyo added a commit to hardyoyo/DSpace that referenced this pull request Nov 7, 2016

Merge pull request DSpace#5 from hardyoyo/DP-22-fix-submission-header
[DP-22] updated the other two possible navbar files with our logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.