[IN-PROCESS] [DS-1144] Maven Project Consolidation #5

Closed
wants to merge 24 commits into
from

Projects

None yet

3 participants

@mdiggory
DSpace Repository member

Pull request to move the maven project consolidation into place in master.

mdiggory added some commits Mar 31, 2012
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate XMLUI. b888969
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Remove XMLUI Subprojects 774c76b
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate discovery XMLUI p…
…rojects
020ef26
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete unneeded discovery XML…
…UI projects
e975304
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate OAI projects cf407a3
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete Unneeded OAI projects 52d8e01
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate JSPUI projects 169877d
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete Unneeded JSPUI projects 082c636
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate SWORD projects 88cbfbc
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete unneeded SWORD projects 4ef6c02
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate SWORD Client proj…
…ects
9073625
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate Discovery Provide…
…r project into dspace-api
591381e
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate remove unneeded S…
…WORD Client Projects
a6afe2f
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate SWORD Client Proj…
…ect into XMLUI
2ef8b2f
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate remove unneeded S…
…WORD Client Projects
c0c1db0
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Fix SWORD Client dependency ac7ffc6
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Consolidate LNI Webapp a512bfa
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete Unneeded LNI projects 197d870
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Delete Unneeded Discovery pro…
…jects
67ad729
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : pull LNI client out of webapp…
… project
b3c9033
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : pull Discovery Solr Provider …
…out of empty discovery project
560f6fd
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Correct parent and pom modules. ad6b7e9
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Remove unneeded discovery par…
…ent.
c015f47
@mdiggory mdiggory [DS-1144] Maven Project Consolidation : Only enable LNI Client if int…
…entionally wanted.
34d95aa
@mdiggory mdiggory closed this Apr 23, 2012
@mdiggory mdiggory reopened this Apr 23, 2012
@mdiggory
DSpace Repository member

Come on folks... How about a little review... This is an example of if you leaving Pull requests floating too long. Now theres more work to do to get this back onto the master.

@tdonohue
DSpace Repository member

Sorry for delayed response.

Honestly, I'd be +1 this change. It's a major re-working of the Maven projects (which could cause some pain for folks upgrading to 3.0 -- but only for those not using 'module' Overlays). But, in my opinion, it's a simplification of our codebase. I've always disliked all the "-api" and "-webapp" subprojects.

I'd say the best way forward is to get a vote in front of the Committers/Developers. Maybe we do this on dspace-devel? Or schedule this for an IRC meeting right after OR12? (Or you could bring it up at OR12 Dev Mtg during the 3.0 session).

For others who may be "intimidated" by the large number of commits/changes in this Pull Request, you can more easily see the new Maven folder structure by just looking at Mark's 'maven-project-consolidation' branch:
https://github.com/mdiggory/DSpace/tree/maven-project-consolidation/

As you'll immediately notice, gone are all the "-api" and "-webapp" submodules for every Web App. Instead, it's a much more simplified codebase, with less Maven projects.

More details at: https://wiki.duraspace.org/display/DSPACE/Maven+Project+Consolidation

@mdiggory
DSpace Repository member

Thanks Tim,

My current thought is that we could hold off on the consolidation until after the feature freeze date or just before the release, this way it will not impact those working on contribution right now. (IMO, I feel the same way about the DAO work) as these are both going to touch a lot of code, I think its important that we organize these to happen at the end.

@ottenhoff

Simplified projects mean lower barrier to entry for new devs. This consolidation makes a lot of sense to me and even though would require a bit of reworking of any customizations I track locally, it's still a +1 to help new devs

@mdiggory mdiggory closed this Oct 3, 2012
@arieljlira arieljlira added a commit to sedici/DSpace that referenced this pull request Jun 9, 2014
@arieljlira arieljlira Agrego xoai parte #5 b16aac5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment