Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[DS-1225] Show display values (input-forms) for controlled vocabularies in ItemTag #54

Merged
merged 1 commit into from Sep 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

iostath commented Aug 7, 2012

EKT's extension to show the display values (input-forms) for controlled vocabularies in ItemTag

https://jira.duraspace.org/browse/DS-1225

Owner

abollini commented Sep 7, 2012

discussion about changes required by this contribution is going in JIRA

@lyncodev lyncodev commented on an outdated diff Sep 12, 2012

dspace-api/src/main/java/org/dspace/app/util/Util.java
+ if (myInputsFound) {
+
+ for (int j = 0; j < values.length; j++){
+
+ String pairsName = myInputs.getPairsType();
+ String stored_value = values[j].value;
+ String displayVal = myInputs.getDisplayString(pairsName,stored_value);
+
+ if (displayVal!=null && !"".equals(displayVal)){
+
+ return displayVal;
+ }
+
+ }
+ }
+
@lyncodev

lyncodev Sep 12, 2012

Owner

Indentation problems (hard to read)

@lyncodev lyncodev commented on an outdated diff Sep 12, 2012

dspace-api/src/main/java/org/dspace/app/util/Util.java
+
+ }
+ }
+ }
+ if (myInputsFound) break;
+ }
+ }
+ if (myInputsFound) {
+
+ for (int j = 0; j < values.length; j++){
+
+ String pairsName = myInputs.getPairsType();
+ String stored_value = values[j].value;
+ String displayVal = myInputs.getDisplayString(pairsName,stored_value);
+
+ if (displayVal!=null && !"".equals(displayVal)){
@lyncodev

lyncodev Sep 12, 2012

Owner

!"".equals(displayVal) is enough

Owner

lyncodev commented Sep 12, 2012

(Developer appreciation)

  • Severe code indentation problems (DSpace code contributions guidelines)

After solving it +1

@abollini abollini pushed a commit that referenced this pull request Sep 17, 2012

abollini Merge pull request #54 from EKT/DS-1225
[DS-1225] Show display values (input-forms) for controlled vocabularies in ItemTag
70a52ca

@abollini abollini merged commit 70a52ca into DSpace:master Sep 17, 2012

@kutsurak kutsurak deleted the EKT:DS-1225 branch Feb 13, 2014

@artlowel artlowel pushed a commit to atmire/DSpace that referenced this pull request Jun 13, 2014

abollini Merge pull request #54 from EKT/DS-1225
[DS-1225] Show display values (input-forms) for controlled vocabularies in ItemTag
d37a351

@hardyoyo hardyoyo pushed a commit to hardyoyo/DSpace that referenced this pull request Oct 23, 2015

Hardy Pottinger Merge pull request #54 from hardyoyo/lso-1477-more-email-markup-corre…
…ctions-to-static-pages

re #1477 fixed a few more broken email links
dc915c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment