[DS-2169] Author profiles for XMLUI #668

Closed
wants to merge 3 commits into
from

Projects

None yet

7 participants

@KevinVdV
Member
KevinVdV commented Oct 1, 2014

Author profiles contribution by the World Bank in collaboration with @mire

@KevinVdV
Member
KevinVdV commented Oct 1, 2014

Please do not merge yet as some more UI cleanup work is still pending.

@bram-atmire bram-atmire changed the title from Author profiles for XMLUI to [DS-2169] Author profiles for XMLUI Oct 1, 2014
@hardyoyo
Member
hardyoyo commented Oct 7, 2014

Hi, the DSpace 5.0 release team is reviewing feature pull requests for possible inclusion for DSpace 5.0, and we see that this PR is not yet complete. We'd like to ask if you foresee being able to complete this work in progress by October 14? If there's anything we can do to help, please don't hesitate to ask. Thanks!

@KevinVdV
Member
KevinVdV commented Oct 8, 2014

Thank you for the interest in this work. To clarify the current state of the work in addition to my previous comment: the core of this code is already running in production. As such, we would recommend to have this current pull request merged "as-is", as soon as possible. Once this initial PR is merged, the remaining few Mirage 2 tweaks will be contributed as additional pull requests. We will try to have those in place as soon as possible.

Our work on the documentation for this feature is in the pipeline as well.

@peterdietz peterdietz commented on the diff Oct 15, 2014
dspace/etc/postgres/database_schema_4_5.sql
+CREATE TABLE authorprofile
+(
+ authorprofile_id INTEGER PRIMARY KEY
+);
+
+
+CREATE TABLE authorprofile2bitstream
+(
+ id INTEGER PRIMARY KEY,
+ authorprofile_id INTEGER REFERENCES authorprofile(authorprofile_id),
+ bitstream_id INTEGER REFERENCES Bitstream(bitstream_id)
+);
+
+CREATE INDEX authorprofile2bitstream_author_profile_fk_idx ON authorprofile2bitstream(authorprofile_id);
+CREATE INDEX authorprofile2bitstream_bitstream_fk_idx ON authorprofile2bitstream(bitstream_id);
@peterdietz
peterdietz Oct 15, 2014 Member

Can this Author Profile db update sql go inside the transaction?
i.e. Postgres transaction logic is:
BEGIN;
-- all your SQL creates/updates
COMMIT;

We're using the transaction, so there's less to break on upgrades.

@peterdietz
Member
  • Developers, you need to run the DB upgrade portion "Author Profiles"
  • This adds a context menu link: "Create new author profile"
  • The create new author form looks like:
    dspace-edit-author-profile
  • The view author profile looks like this:
    dspace-author-profile-dietz
  • Is autocomplete supposed to be enabled, when searching for an author? Or is this a generic discovery feature that I don't have enabled locally?

Other than that, this appears to work fine.

@hardyoyo
Member

There appear to be merge conflicts with this PR and the ORCID PR (#612)... can you investigate and advise?

@hardyoyo
Member

Sorry for the mis-information, I was wrong about the ORCID PR, the conflict must be with Master (GitHub seems to have noticed it, too). It was easy for me to complete the merge manually, you probably just need to rebase on master.

@pnbecker pnbecker commented on the diff Oct 19, 2014
...i/src/main/java/org/dspace/content/AuthorProfile.java
+ TableRow bitstreamLinkRow = DatabaseManager.querySingleTable(context, "authorprofile2bitstream", "SELECT bitstream_id FROM authorprofile2bitstream WHERE authorprofile_id = ?", getID());
+ if(bitstreamLinkRow == null)
+ {
+ authorProfile = null;
+ }else{
+ authorProfile = Bitstream.find(context, bitstreamLinkRow.getIntColumn("bitstream_id"));
+ }
+
+
+ // Cache ourselves
+ context.cache(this, row.getIntColumn("authorprofile_id"));
+ clearDetails();
+ }
+
+ /**
+ * Create a new eperson
@pnbecker
pnbecker Oct 19, 2014 Contributor

Copy paste? Shouldn't this create a new author or authorProfile?

@KevinVdV
KevinVdV Oct 20, 2014 Member

To create a new AuthorProfile one must call AuthorProfile.create(context). This is similar to all other DSpace objects creation.

@hardyoyo hardyoyo modified the milestone: 5.0-feature-freeze Oct 22, 2014
@peterdietz peterdietz added this to the post-5 milestone Oct 28, 2014
@jaideraf
jaideraf commented Aug 3, 2015

This is a great feature, can we expect this feature present in the DSpace 6 version series?

@tdonohue tdonohue removed this from the post-5 milestone Aug 18, 2015
@bram-atmire
Member

This pull request is closed because:

  • there is still discussion in the JIRA whether DSpace should come with such a feature out of the box or not
  • Major rework needs to happen on this code anyway to make it compatible with the new DSpace 6 API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment