[DS-2447] Booleans from altmetrics.cfg don't work properly. #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,10 +40,10 @@ | |||
|
|
|||
| <xsl:template name="itemSummaryView-DIM"> | |||
| <!-- optional: Altmeric.com badge and PlumX widget --> | |||
| <xsl:if test='confman:getProperty("altmetrics", "altmetric.enabled") and ($identifier_doi or $identifier_handle)'> | |||
| <xsl:if test="confman:getProperty('altmetrics', 'altmetric.enabled') = 'true' and ($identifier_doi or $identifier_handle)"> | |||
There was a problem hiding this comment.
This PR will need to be updated for the enhanced Configuration system (see #1104).
The confman:getProperty calls all call the ConfigurationManager. Now, if you pass it two params, they are just appended together. So, this call will end up trying to load a property named altmetrics.altmetric.enabled from altmetrics.cfg. The correct property is simply altmetric.enabled
rivaldi8
force-pushed
the
DS-2447-booleans-altmetrics.cfg
branch
from
f7a4fc9
to
98c453b
Compare
|
I've updated the pull request removing the configuration prefix. |
|
Closing as this PR must be recreated on |
kosarko
added a commit
to kosarko/DSpace
that referenced
this pull request
Jul 10, 2018
* Debug logging from PiwikTracker * Limit what's tracked
frabacche
pushed a commit
to 4Science/DSpace
that referenced
this pull request
Mar 27, 2024
[CST-10326] Changed the relationAuthorResearchOutputsConfiguration defaultFilterQueries. Now edited books show up on the individual profile page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.duraspace.org/browse/DS-2447