DS-2520: Modify XPath expression when retrieving a workflow step #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @FacundoAdorno ! It looks reasonable at a glance (though I admit to be less familiar with this area of the code). We just need to find someone to give it a quick test. |
When we have two workflows, W1 and W2, and W2 has a first step with a ID equal to other step ID in W1, WorkflowFactory retrieves erroneously the step in W1 when we ask about the first step in W2. To prevent this, the corresponding XPath expression was modified.
FacundoAdorno
force-pushed
the
DS-2520
branch
from
12649c0
to
52a3f62
Compare
|
Hi! I have solved the merge conflict. Regards! |
tdonohue
added
the
quick win
|
+1 by inspection, I have not tested it, but I concur with the analysis on the Jira issue, removing the // from the xpath is required to facilitate the workflow configuration example given on the ticket. |
|
Took it for a quick test run, works as advertised, so merging. Thanks @FacundoAdorno |
|
You are welcome. Regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have two workflows, W1 and W2, and W2 has a first
step with a ID equal to other step ID in W1, WorkflowFactory
retrieves erroneously the step in W1 when we ask about the
first step in W2.
To prevent this, the corresponding XPath expression was modified.
See JIRA issue for more details.