[CC License support] Addingresponse to "rightsByQuestions" #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…& what the purpose of it is.
tdonohue
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
👍 Looks good to me for now. As noted in a separate comment, we (meaning the DSpace 7 team) may wish to analyze where we are creating new Submission-feature endpoints. We have an inconsistency in that some are under /api/config/ (prefixed by "submission"), while others are under /api/submission/. I suspect we may want to move most/all to the latter path at some point, but that could be done in a follow-up PR.
|
Merging this as the change here is really tiny & based on my feedback in the implementation PR at DSpace/DSpace#2764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mention in the PR: DSpace/DSpace#2764, this PR will clarify the response of the /api/config/submissioncclicenses/search/rightsByQuestions endpoint.