Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align REST Search contract with Angular UI requirements #21

Merged
merged 2 commits into from May 19, 2018

Conversation

@tomdesair
Copy link
Contributor

tomdesair commented Apr 20, 2018

This PR (kudos to @Raf-atmire) aligns the DSpace REST API Search contract with additional fields to make the life of our Angular UI developers easier.

It also corrects the pagination of search results so that pagination information (fields + links) are present on the correct level.

@tomdesair tomdesair changed the title Align search contract with angular Align REST Search contract with Angular UI requirements Apr 20, 2018
@tomdesair tomdesair force-pushed the atmire:align-search-contract-with-angular branch from cdd7605 to bb600e2 Apr 20, 2018
Copy link
Member

abollini left a comment

the changes look good to me.
I just noted an id that we have in the response but we could eventually remove from the contract as it is unnecessary and I will prefer to remove from the current response as well when possible (task a lower priority).
If you agree please merge and create a JIRA issue to fix the implementation

@@ -444,39 +521,70 @@ The list of returned facet fields will depend on the Discovery configuration: ht
The JSON response document is as follow
```json
{
"id": null,

This comment has been minimized.

Copy link
@abollini

abollini Apr 23, 2018

Member

is this really needed?

This comment has been minimized.

Copy link
@tomdesair

tomdesair Apr 26, 2018

Author Contributor

I agree, I'll see what we can do about it

@abollini abollini merged commit c4905da into DSpace:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.