Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Issues #119

Closed
artlowel opened this issue Jun 23, 2017 · 2 comments
Closed

Pagination Issues #119

artlowel opened this issue Jun 23, 2017 · 2 comments
Assignees
Labels
bug

Comments

@artlowel
Copy link
Member

@artlowel artlowel commented Jun 23, 2017

Switching to changeDetection.OnPush in this commit has the effect that changing the page size no longer works. This points to an underlying problem that not all state of the pagination component is stored in the ngrx store, otherwise onPush would work.

Another likely related issues is that if you go to the second page of a paginated list, click on an item and use the browser's back button, you see the results of the first page, but the second page is still highlighted

@atarix83 atarix83 self-assigned this Jun 30, 2017
@atarix83 atarix83 added in progress and removed ready labels Jun 30, 2017
@atarix83

This comment has been minimized.

Copy link
Contributor

@atarix83 atarix83 commented Jul 5, 2017

I should have solved the resize issue by adding local change detection checks as here.

About the second issue I think that the right behavior should be to get back to the last page visited, that in the example is the second page. In this case I've seen that the PaginationComponent works properly, should it be an issue related to cache or REST call? I've tested a simple paginated list page and the same use case works well.

@wwelling

This comment has been minimized.

Copy link
Contributor

@wwelling wwelling commented Jul 14, 2017

Pagination has a glitch with universal. When the prerender finishes and swaps the cache on the client the pagination switches to the first page and back to the desired page quickly. It is noticible in development mode and more so with replay redux prerender strategy. In production mode with rehydrate prerender strategy, it happens but so quick it cannot be noticed. If the console is opened, it slows everything down enough to notice it even in production mode.

This may be an issue with ngx-pagination library. Does it fully support Angular Universal?

The desired behavior would be to never fetch and render any page but the page described in the query string.

This is required for smooth page refresh and deep linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.