Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervised Order with OBSERVER permissions shows too many buttons on MyDSpace. #2094

Closed
tdonohue opened this issue Feb 14, 2023 · 1 comment · Fixed by #2226
Closed

Supervised Order with OBSERVER permissions shows too many buttons on MyDSpace. #2094

tdonohue opened this issue Feb 14, 2023 · 1 comment · Fixed by #2226
Assignees
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back component: MyDSpace
Milestone

Comments

@tdonohue
Copy link
Member

Describe the bug
Discovered during final testing of #2019

The issue is on the "MyDSpace -> Supervised Items" when "OBSERVER" permissions are assigned. Obviously, if you are just an OBSERVER, you should only be able to view the Item. But, the buttons displayed imply you can do more.

Here's want an OBSERVER sees on MyDSpace:
observer-view
(I'd expect that the "Delete" and "Edit" Buttons should not appear. They should only have the "View" option")

That said, I've confirmed that clicking "Delete" doesn't work. If the OBSERVER clicks "Edit", they are able to load the submission form... but they are unable to save any changes to the form.

To Reproduce
Steps to reproduce the behavior:

  1. Login as an Admin & create a Supervision Order (from Administrative Workflow), assigning a Group with OBSERVER permissions
  2. Logout & Login as a member of that group
  3. Go to "MyDSpace -> Supervised Items". Verify you see the Supervised Item, but also see an "Edit" and "Delete" button.

Expected behavior
Edit & Delete button should not appear on MyDSpace page for the OBSERVER role. An OBSERVER can only view the supervised item.

Related work
Related to #2019

@tdonohue
Copy link
Member Author

@atarix83 : This is the final (minor) issue that I located in #2019. If there's a very quick fix, let me know & we could still try to get it into 7.5. If it needs work / more analysis, then we'll wait till 7.6 to resolve this.

@corrad82-4s corrad82-4s added claimed: 4Science 4Science team is working on this issue & will contribute back and removed claimed: 4Science 4Science team is working on this issue & will contribute back labels Mar 16, 2023
@abollini abollini added the claimed: 4Science 4Science team is working on this issue & will contribute back label Mar 29, 2023
@tdonohue tdonohue added this to the 7.6 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back component: MyDSpace
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants