Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceBypassCache should be removed from the RequestService #394

Open
artlowel opened this issue May 10, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@artlowel
Copy link
Member

commented May 10, 2019

When the submission and MyDspace code was originally written, all requests were cached and for the same amount of time. This was an issue because a POST requests would get cached as well so subsequent POSTs wouldn't be executed etc.

To work around this problem a forceBypassCache param was added to the RequestService that would ensure the request would be sent without first looking for a cached response.

This problem has been fixed. Only GET requests are cached now, and when creating a request you can specify how long its response should be cached, so all instances where forceBypassCache is used can be refactored, and the param can be removed from the RequestService.

@artlowel artlowel added the ready label May 10, 2019

@artlowel artlowel referenced this issue May 10, 2019

Merged

Mydspace #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.