Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ngrx platform #86

Closed
artlowel opened this issue Apr 27, 2017 · 1 comment
Closed

Switch to ngrx platform #86

artlowel opened this issue Apr 27, 2017 · 1 comment
Assignees

Comments

@artlowel
Copy link
Member

@artlowel artlowel commented Apr 27, 2017

The next version of ngrx will combine their most commonly used separate modules in to a single module: platform. It will bring their versions in sync with Angular's. It hasn't been released yet.

There will be a few breaking changes. Nothing problematic for us at first sight. Here is the migration guide

@wwelling wwelling self-assigned this Jul 13, 2017
artlowel added a commit that referenced this issue Jul 20, 2017
Angular upgrade: this connects to #83 and this connects to #86
@artlowel artlowel added in progress and removed ready labels Jul 26, 2017
@artlowel artlowel self-assigned this Jul 26, 2017
@artlowel

This comment has been minimized.

Copy link
Member Author

@artlowel artlowel commented Aug 1, 2017

I'll have to put this on hold. Everything is ported, but I get an exception when I try to JSON.stringify the router's state, in order to transfer it from the server to the client. It is a known issue with ngrx platform, see ngrx/platform#150, which links to ngrx/platform#97

I'll pick this up again when ngrx/platform#97 is fixed

@artlowel artlowel removed the in progress label Aug 1, 2017
@ghost ghost added the in progress label Sep 7, 2017
@artlowel artlowel added needs review and removed in progress labels Sep 7, 2017
@artlowel artlowel closed this Sep 18, 2017
@artlowel artlowel removed the needs review label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.