Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live REST API & Dso list component #117

Merged
merged 42 commits into from Jun 23, 2017
Merged

Conversation

@artlowel
Copy link
Member

artlowel commented Jun 22, 2017

This PR connects to #98 and connects to #111

It contains:

  • The switch to the live REST API
  • The DSO List component
  • A start to the Browse Component (but still in strong need of refactoring)

My apologies for the fact that it isn't split up neater, but I'm out of time.

Known issues:

  • Going to the URL of any page in a paginated list will always send you to the first page
  • Downloaded files will always have the filename "retrieve"
artlowel and others added 30 commits Jun 2, 2017
# Conflicts:
#	src/app/collection-page/collection-page.module.ts
#	src/app/collection-page/logo/collection-page-logo.component.html
#	src/app/collection-page/logo/collection-page-logo.component.ts
…f it was fetched as part of a list, and later queried as a single resource
artlowel added 4 commits Jun 22, 2017
@artlowel

This comment has been minimized.

Copy link
Member Author

artlowel commented Jun 22, 2017

Going to the URL of any page in a paginated list will always send you to the first page

The last commit fixes this issue

@tdonohue

This comment has been minimized.

Copy link
Member

tdonohue commented Jun 22, 2017

@artlowel : apologies, I didn't get to testing this. But, I'd say go ahead and merge once you are satisfied. If you have any concerns, we can wait to merge post-OR2017, and simply use your demo site for any demos at OR.

@rivaldi8

This comment has been minimized.

Copy link
Contributor

rivaldi8 commented Jun 23, 2017

I've tested it a bit and all seems to work properly. I've just found a minor issue between the pagination and the browser's back button.

For example, if you navigate to the item of the second page of the collection's item list, then go back in history, it goes to the first page of the item list instead of to the second. The pagination shows the second page as active, though.

@artlowel

This comment has been minimized.

Copy link
Member Author

artlowel commented Jun 23, 2017

@rivaldi8 I can reproduce the problem but I'm going to merge it, and open a separate issue for it

@artlowel artlowel merged commit afc3902 into DSpace:master Jun 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@artlowel artlowel removed the needs review label Jun 23, 2017
@artlowel artlowel deleted the artlowel:dso-list-component branch Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.