Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Item-Collection mapper #348
This feature is based on the “Mapped collections” feature in DSpace6.
tdonohue left a comment
I began to give this a code review today, and added a few inline comments below. However, I'm seeing a lot of seemingly unrelated changes in this PR which almost look like this PR's branch is not updated to use Angular 6.
@artlowel or @LotteHofstede could you take a closer look at this PR? The changes to various (seemingly unrelated) components/services seem rather odd to me, as they look to be reverting recent changes.
I tried to review this PR again today, but I'm having a hard time doing a code review. It looks like it contains most of the changes in #349, but seems to have possibly diverged at some point... so attempting to diff this branch with that of #349 doesn't seem to be working.
I suspect we need to get #349 updated/merged quickly (it's nearly there) and then rebase this PR to make it easier to review.