Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated accessibility to CI #356

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@courtneypattison
Copy link
Contributor

courtneypattison commented Jan 28, 2019

Somewhat fixes #209

I added pa11y-ci to the CI but I set a threshold of 1000 errors before exiting > 0 because the accessibility errors haven't been fixed so I don't want the CI to fail. It's hard to test CI without submitting code so I'm not sure if this will work! I'd be happy to work on the accessibility errors if you'd like and/or change this PR to suit everyone's needs better. Just let me know what is needed :)

@courtneypattison

This comment has been minimized.

Copy link
Contributor Author

courtneypattison commented Jan 29, 2019

Sorry for all the noise! I realized after submitting this PR, I could have just tested the CI on my fork using Travis. I moved the stderr from rollup to /dev/null because it was making the log output so long that Travis would fail when I ran yarn start. It's a quick fix that I'm not sure is a great idea, but I just wanted to get the CI running. Same idea with the switch to only testing with node 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.