Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Administrative Item Edit #362
When logged on as an administrator, a user can now edit an item's metadata.
The edit metadata page can be found at
On this page you will be able to add, delete and edit metadata fields. The changes you make will be stored in the ngrx store - even if you don't immediately save them - and will be available as long as you don't refresh the page.
To add a new metadata field, click the large green
To remove an existing metadata field, click the red
To edit an existing metadata field, click the blue
Close edit mode
To close edit mode and display a field without the input fields, click the green
Discard changes of a single field
To undo all changes made to a single field, click the orange
Discard all changes to all fields
To discard all changes you made, click the orange 'Discard' button at the top of the page.
Note that you can only use the
To save all the changes you made to the item, click the save button. This will send an actual request to the backend and update the item.
paulo-graca left a comment
Overall, this is PR it's ok by me. I just have minor change suggestions.
One strange thing that happed with me... when I was first testing this PR, the changes I made to metadata it only be visible at DB layer, I had to do a page refresh after saving to see those changes. But this stopped occuring and I couldn't replicate it anymore.
tdonohue left a comment
@LotteHofstede : I gave this a thorough review and test today. It's honestly looking great overall. Thank you so much for all the detailed TypeDocs & inline comments! Thank you also for the refactoring work -- I agree it's much easier to understand now. That said, I did add a few (minor) inline comments that I'd like addressed.
With regards to testing, the functionality works great! I like the overall design & look and feel. I only had one minor usability issue that I encountered:
I don't see that as a major bug that warrants fixing immediately. But, I think it is a usability issue, and we should log it as a known bug, if we decide not to fix it in this PR.
So, overall, I think this is great work