Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configurable Entities] new data tweaks #390

Merged
merged 37 commits into from May 10, 2019

Conversation

artlowel
Copy link
Member

  • Configure the metadata fields on entity pages to be more suited to the new data that was added to the entities demo db.
  • Replace the entities placeholder images with more consistent, scalable ones
  • Add the ability to render entities of different types as MetadataRepresentations in the same list. The UI used to assume all entities in the same list had the same type, but the new data has cases where there are both OrgUnits and Persons as dc.contributor.author virtual metadata for the same Publication

bram-atmire and others added 30 commits October 31, 2018 22:45
…typedoc

Improved test coverage and TypeDoc
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. Gave this a quick test and it seems to be working fine. The code changes here are primarily configuration updates and template changes. There are some code refactors & additional specs/tests added, but no of them jump out as concerning.

I'm going to go ahead and merge this into the configurable_entities branch so that it can be more easily tested/merged along with the rest of that code.

@tdonohue tdonohue merged commit 7727d4a into DSpace:configurable_entities May 10, 2019
@ghost ghost removed the needs review label May 10, 2019
@benbosman benbosman deleted the entities_new_data_tweaks branch September 11, 2020 07:53
@tdonohue tdonohue added this to the 7.0preview milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants