Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pree2e' and 'ci' scripts added #51

Merged
merged 4 commits into from Mar 13, 2017
Merged

'pree2e' and 'ci' scripts added #51

merged 4 commits into from Mar 13, 2017

Conversation

@sourcedump
Copy link
Contributor

sourcedump commented Jan 31, 2017

This PR connects to #49.

'pree2e' and 'ci' scripts added.
'pree2e', runned each time 'e2e' is called, keeps protractor drivers up to date while 'ci' runs tslint and all the tests (both Unit tests and E2E tests).

@artlowel

This comment has been minimized.

Copy link
Member

artlowel commented Feb 1, 2017

LGTM

@sourcedump

This comment has been minimized.

Copy link
Contributor Author

sourcedump commented Feb 1, 2017

Actually you need to run a 'start:dev' manually before executing 'ci' (for e2e testing).
Do you think it's possible to run 'start:dev' and, when the server is up, auto-run 'ci' and, again, at the end, shutdown the server started with 'start:dev'?

@sourcedump

This comment has been minimized.

Copy link
Contributor Author

sourcedump commented Feb 21, 2017

Ok, the 'ci' script now runs the 'server' and 'e2e' toghether after a build.

@artlowel

This comment has been minimized.

Copy link
Member

artlowel commented Feb 22, 2017

It works, but are you using npm-run-all in order to run two npm scripts in parallel? If so, note that we already have a dependency on concurrently that does the same thing.

@sourcedump

This comment has been minimized.

Copy link
Contributor Author

sourcedump commented Mar 2, 2017

Hello Art, I've tryed to use 'concurrently' but I need to use the '-k' option to kill the server at the end of the tests and with 'npm-run-all' all is fine, instead with 'concurrently' I have a false error at the end of the run. All the scripts run correctly but at the end an error is reported. I'll try to figure out why.

@artlowel

This comment has been minimized.

Copy link
Member

artlowel commented Mar 9, 2017

If you can't get it to work, I'm also fine with swapping out concurrently for npm-run-all everywhere (it's only used for two scripts), as long as npm-run-all also works on all platforms. It's just that I'd rather not add two dependencies to do the same job.

@sourcedump

This comment has been minimized.

Copy link
Contributor Author

sourcedump commented Mar 13, 2017

I've relplaced 'concurrently' with 'npm-run-all'. Now all is fine.

@artlowel

This comment has been minimized.

Copy link
Member

artlowel commented Mar 13, 2017

LGTM. Merging

@artlowel artlowel merged commit 976a0ec into DSpace:master Mar 13, 2017
@artlowel artlowel removed the needs review label Mar 13, 2017
@sourcedump sourcedump deleted the 4Science:all-test branch Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.