From 1f582d133af1b06921f5058832e720999f35e31d Mon Sep 17 00:00:00 2001 From: guillermo2519 Date: Mon, 4 May 2026 17:35:01 -0600 Subject: [PATCH] fix #5544: enlarge dropdown for external source import --- ...bmission-import-external-searchbar.component.scss | 3 ++- ...ssion-import-external-searchbar.component.spec.ts | 12 ++++++++++-- ...submission-import-external-searchbar.component.ts | 4 ++-- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.scss b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.scss index 97f49459c7c..b96822357c9 100644 --- a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.scss +++ b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.scss @@ -13,8 +13,9 @@ .scrollable-menu { height: auto; - max-height: calc(var(--ds-dropdown-menu-max-height) / 2); + max-height: calc(var(--ds-dropdown-menu-max-height) * 2); overflow-x: hidden; + overflow-y: auto; } .scrollable-dropdown-loading { diff --git a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts index 79bab03c36c..9203f9be1d8 100644 --- a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts +++ b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.spec.ts @@ -140,17 +140,25 @@ describe('SubmissionImportExternalSearchbarComponent test suite', () => { expect(comp.selectedElement).toEqual(selectedElement); }); + it('Should use elementsPerPage of 20 on init', () => { + comp.initExternalSourceData = { entity: 'Publication', sourceId: '', query: '' }; + scheduler.schedule(() => fixture.detectChanges()); + scheduler.flush(); + + expect(compAsAny.findListOptions.elementsPerPage).toEqual(20); + }); + it('Should load additional external sources', () => { comp.initExternalSourceData = { entity: 'Publication', query: 'dummy', sourceId: 'ciencia' }; comp.sourceListLoading = false; compAsAny.pageInfo = new PageInfo({ - elementsPerPage: 3, + elementsPerPage: 20, totalElements: 6, totalPages: 2, currentPage: 0, }); compAsAny.findListOptions = Object.assign({}, new FindListOptions(), { - elementsPerPage: 3, + elementsPerPage: 20, currentPage: 0, searchParams: [ new RequestParam('entityType', 'Publication'), diff --git a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.ts b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.ts index ee86deee284..bdbae89bb02 100644 --- a/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.ts +++ b/src/app/submission/import-external/import-external-searchbar/submission-import-external-searchbar.component.ts @@ -142,7 +142,7 @@ export class SubmissionImportExternalSearchbarComponent implements OnInit, OnDes this.searchString = ''; this.sourceList = []; this.findListOptions = Object.assign({}, new FindListOptions(), { - elementsPerPage: 5, + elementsPerPage: 20, currentPage: 1, searchParams: [ new RequestParam('entityType', this.initExternalSourceData.entity), @@ -187,7 +187,7 @@ export class SubmissionImportExternalSearchbarComponent implements OnInit, OnDes if (!this.sourceListLoading && ((this.pageInfo.currentPage + 1) <= this.pageInfo.totalPages)) { this.sourceListLoading = true; this.findListOptions = Object.assign({}, new FindListOptions(), { - elementsPerPage: 5, + elementsPerPage: 20, currentPage: this.findListOptions.currentPage + 1, searchParams: [ new RequestParam('entityType', this.initExternalSourceData.entity),