Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to mock data #97

Merged
merged 3 commits into from Jun 1, 2017
Merged

Add type to mock data #97

merged 3 commits into from Jun 1, 2017

Conversation

@artlowel
Copy link
Member

artlowel commented May 23, 2017

This PR adds the type property to the mock data, as it is in the current rest demo and will be needed in a future task

It also anticipates on an issue with the bootstrap that will happen once #95 is merged and bootstrap is upgraded. I used the .row class to offset the gutter widths for the news component, but that will break in the new version, so I made a dedicated mixin to do so.

@ghost ghost assigned artlowel May 23, 2017
@ghost ghost added the needs review label May 23, 2017
@artlowel artlowel merged commit 57f4254 into DSpace:master Jun 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost ghost removed the needs review label Jun 1, 2017
@artlowel artlowel deleted the artlowel:add-type-to-mock-data branch Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.