Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded resources in rest responses #99

Merged
merged 5 commits into from Jun 14, 2017

Conversation

@artlowel
Copy link
Member

artlowel commented Jun 1, 2017

This PR connects to #31 and #32

It adds support for embedded resources in rest responses, it also refactors a few things.

This PR depends on #97

@ghost ghost assigned artlowel Jun 1, 2017
@ghost ghost added the needs review label Jun 1, 2017
@tdonohue

This comment has been minimized.

Copy link
Member

tdonohue commented Jun 5, 2017

@artlowel : I've done a quick code review here, and this all seems to make some sense, based on the restructuring of the static data (src/backend/*.ts). I'm not sure how best to test this, but the fact that unit tests still succeed seems to be a good sign here. Is this ready to merge, or were there further tests you were looking for here?

@artlowel

This comment has been minimized.

Copy link
Member Author

artlowel commented Jun 6, 2017

You can test it by looking at the network requests on e.g. the item page, on master it will fetch every bundle, bitstream and collection separately, on this PR branch it should request the Item itself, but not the bundles, bitstreams and collections that are embedded in the mock data.

If you remove any of those embedded resources from the Item mock data, you should see that it will again fetch those seperately.

@artlowel artlowel merged commit ba62a64 into DSpace:master Jun 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost ghost removed the needs review label Jun 14, 2017
@artlowel artlowel deleted the artlowel:rest-embedded branch Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.