Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bitbucket filter #164

Merged
merged 36 commits into from Dec 6, 2019
Merged

Feature/bitbucket filter #164

merged 36 commits into from Dec 6, 2019

Conversation

@adelkahomolova
Copy link
Member

adelkahomolova commented Nov 19, 2019

Add possibility to filter pullrequests.

@adelkahomolova adelkahomolova requested a review from prokopsimek as a code owner Nov 19, 2019
@adelkahomolova adelkahomolova self-assigned this Nov 19, 2019
src/inspectors/CollaborationInspector.ts Outdated Show resolved Hide resolved
src/services/bitbucket/BitbucketService.ts Outdated Show resolved Hide resolved
src/services/git/GitHubService.ts Outdated Show resolved Hide resolved
src/services/git/ICVSService.ts Outdated Show resolved Hide resolved
src/inspectors/IssueTrackingInspector.ts Outdated Show resolved Hide resolved
src/model.ts Outdated Show resolved Hide resolved
src/services/bitbucket/BitbucketService.ts Outdated Show resolved Hide resolved
src/services/bitbucket/BitbucketService.ts Outdated Show resolved Hide resolved
src/services/bitbucket/BitbucketService.ts Outdated Show resolved Hide resolved
test/helpers/bitbucketNock.ts Show resolved Hide resolved
src/services/git/GitHubService.ts Outdated Show resolved Hide resolved
src/services/git/CSVServicesUtils.ts Outdated Show resolved Hide resolved
src/services/git/CSVServicesUtils.ts Outdated Show resolved Hide resolved
src/services/git/CSVServicesUtils.ts Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #164 into master will increase coverage by 0.22%.
The diff coverage is 95.52%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   86.91%   87.13%   +0.22%     
==========================================
  Files         124      126       +2     
  Lines        2667     2752      +85     
  Branches      384      403      +19     
==========================================
+ Hits         2318     2398      +80     
- Misses        349      354       +5
Impacted Files Coverage Δ
...tbucketServiceMockFolder/getPullRequestResponse.ts 100% <ø> (ø) ⬆️
src/inspectors/ICollaborationInspector.ts 100% <ø> (ø)
src/model.ts 100% <ø> (ø) ⬆️
src/services/git/GitHubService.ts 94.61% <100%> (+0.17%) ⬆️
src/services/git/IVCSService.ts 100% <100%> (ø)
test/helpers/bitbucketNock.ts 98.19% <100%> (+0.76%) ⬆️
src/services/bitbucket/BitbucketService.ts 75.6% <100%> (+3.28%) ⬆️
src/inspectors/CollaborationInspector.ts 100% <100%> (ø) ⬆️
src/services/git/Git.ts 94.25% <100%> (ø) ⬆️
src/inspectors/IssueTrackingInspector.ts 100% <100%> (ø) ⬆️
... and 4 more
adelkahomolova and others added 12 commits Nov 25, 2019
Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
@adelkahomolova adelkahomolova changed the title Feature/bitbucket filter [WIP] Feature/bitbucket filter Nov 27, 2019
…feature/BitBucket-filter

# Conflicts:
#	package.json
#	src/services/bitbucket/BitbucketService.spec.ts
#	test/helpers/bitbucketNock.ts
@adelkahomolova adelkahomolova requested a review from prokopsimek Dec 4, 2019
adelkahomolova and others added 7 commits Dec 4, 2019
fix: use better syntax

Co-Authored-By: Prokop Simek <prokopsimek@users.noreply.github.com>
@adelkahomolova adelkahomolova changed the title [WIP] Feature/bitbucket filter Feature/bitbucket filter Dec 6, 2019
@adelkahomolova adelkahomolova requested a review from prokopsimek Dec 6, 2019
…feature/BitBucket-filter
@@ -77,22 +111,48 @@ export class BitbucketNock {
}
return interceptor;
}

mockBitbucketPullRequestResponse(states: BitbucketPullRequestState | BitbucketPullRequestState[]): Paginated<PullRequest> {

This comment has been minimized.

Copy link
@prokopsimek

prokopsimek Dec 6, 2019

Member
Suggested change
mockBitbucketPullRequestResponse(states: BitbucketPullRequestState | BitbucketPullRequestState[]): Paginated<PullRequest> {
mockBitbucketPullRequestsResponse(states: BitbucketPullRequestState | BitbucketPullRequestState[]): Paginated<PullRequest> {
@prokopsimek prokopsimek self-requested a review Dec 6, 2019
@adelkahomolova adelkahomolova merged commit e859a6a into master Dec 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adelkahomolova adelkahomolova deleted the feature/BitBucket-filter branch Dec 6, 2019
@prokopsimek

This comment has been minimized.

Copy link
Member

prokopsimek commented Dec 6, 2019

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prokopsimek prokopsimek added the released label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.