Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Bitbucket get repo commits #165

Merged
merged 18 commits into from Nov 28, 2019
Merged

Conversation

@adelkahomolova
Copy link
Member

adelkahomolova commented Nov 19, 2019

Implement getRepoCommits() into BitbucketService. Add test for that.

@adelkahomolova adelkahomolova requested a review from prokopsimek as a code owner Nov 19, 2019
@adelkahomolova adelkahomolova self-assigned this Nov 19, 2019
src/services/git/model.ts Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #165 into master will increase coverage by 0.16%.
The diff coverage is 95.83%.

@@            Coverage Diff            @@
##           master    #165      +/-   ##
=========================================
+ Coverage   86.54%   86.7%   +0.16%     
=========================================
  Files         122     123       +1     
  Lines        2623    2640      +17     
  Branches      381     381              
=========================================
+ Hits         2270    2289      +19     
+ Misses        353     351       -2
Impacted Files Coverage Δ
...ucketServiceMockFolder/getIssueCommentsResponse.ts 100% <ø> (ø) ⬆️
...tbucketServiceMockFolder/getPullRequestResponse.ts 100% <ø> (ø) ⬆️
src/services/git/model.ts 100% <ø> (ø) ⬆️
test/helpers/bitbucketNock.ts 97.29% <100%> (+0.37%) ⬆️
...CKS__/bitbucketServiceMockFolder/getRepoCommits.ts 100% <100%> (ø)
src/services/bitbucket/BitbucketService.ts 69.72% <91.66%> (+3.05%) ⬆️
src/inspectors/FileInspector.ts 82.08% <0%> (+1.49%) ⬆️
prokopsimek and others added 3 commits Nov 25, 2019
@prokopsimek prokopsimek self-requested a review Nov 28, 2019
@prokopsimek prokopsimek merged commit 5d2b961 into master Nov 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@prokopsimek prokopsimek deleted the feature/bbucket-get-repo-commits branch Nov 28, 2019
prokopsimek pushed a commit that referenced this pull request Nov 28, 2019
# [1.21.0](v1.20.0...v1.21.0) (2019-11-28)

### Bug Fixes

* add email of an author ([ec651b5](ec651b5))
* add the return type ([dfe3320](dfe3320))
* add type of mocked response and fix the response ([869c21a](869c21a))
* add type to repoCommits ([e3953ea](e3953ea))
* auth is possibly undefined ([dc1f0f4](dc1f0f4))
* mocked response ([6c5a7cb](6c5a7cb))
* return repo commit in own interface ([c1cd1e4](c1cd1e4))
* tests and interfaces ([c746286](c746286))
* use one interface for both PullCommits and RepoCommits ([e936108](e936108))
* via #165 (comment) ([9052e1f](9052e1f)), closes [/github.com//pull/165#discussion_r348598072](https://github.com//github.com/DXHeroes/dx-scanner/pull/165/issues/discussion_r348598072)

### Features

* add RepoCommit and RepoCommits class; ([9ccfead](9ccfead))
* implement getRepoCommits() ([8cd4fec](8cd4fec))
@prokopsimek

This comment has been minimized.

Copy link
Member

prokopsimek commented Nov 28, 2019

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.