Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Creation - able to select asset with 0 value and create Proposal #165

Closed
Filipv95 opened this issue Jul 29, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@Filipv95
Copy link
Contributor

Description
I have created Contributor Proposal and added Transfer&Mint action, and I selected DEX for asset, and I entered certain value in Amount field, and successfully created Proposal. Then I voted fo that option as well.

Steps to Reproduce

  1. SpinUp Localhost env
  2. Open localhost:3000
  3. Check if Landing Page is loaded
  4. Connect wallet
  5. Click on SWPRGuild box
  6. Click on Create Proposal button
  7. Add Proposal Title and Description
  8. Add Option
  9. Click on assed drop-down and select DXD token
  10. Enter some amount in Amount Field
  11. Save Action
  12. Create Proposal

Expected behavior
I should not be able to create Proposal in the first place when selected asset has no value

Screenrecord
https://user-images.githubusercontent.com/37701286/181804160-54373864-6124-4a6c-8d63-8b4f8fecccb2.mp4

Device Information
OS: MacOs
Browser GoogleChrome, Brave
Device: MacOS Monterey v12.4

Additional context
Perhaps some extra validation should be added here as well

@Filipv95 Filipv95 added the bug Something isn't working label Jul 29, 2022
@rossneilson
Copy link
Contributor

This looks like a regression from #149 @MiltonTulli can you replicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants