Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TokenPicker): Implement native token support. #218

Merged

Conversation

mprasanjith
Copy link
Member

@mprasanjith mprasanjith commented Aug 15, 2022

Description

Implements native token support for asset transfers in the action builder seamlessly alongside ERC20 transfers.

Closes #141.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally and using the existing test suite.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@mprasanjith mprasanjith self-assigned this Aug 15, 2022
@mprasanjith mprasanjith added enhancement New feature or request Action Builder labels Aug 15, 2022
@mprasanjith mprasanjith marked this pull request as ready for review August 15, 2022 20:30
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 72e2d11

😎 Browse the preview: https://bafybeihgq74ogfqnmtoasb7rdjd4ozepjopume7kizpcbex3efteqw7l4y.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeidr5hbvkjax5a7r56bg56tljec7ksvknwvq45ssgscs7hocg4t4ra.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 49c2bb0

😎 Browse the preview: https://bafybeie7vllwwovbztovakdpapr7kjl235mnzse5tjshoa7iym4bxjmuxu.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeiews7dpdnputsnkxvmiawarctt4qb43fhb5tuxkawi4r5qa2wvbqq.ipfs.cf-ipfs.com

rossneilson
rossneilson previously approved these changes Aug 18, 2022
@Filipv95
Copy link
Contributor

@rossneilson How can this be tested?

@rossneilson
Copy link
Contributor

We have a new token that can be transferred, should show as ethereum on testnet and goerli

@Filipv95
Copy link
Contributor

@rossneilson I've check this, new token is visible as 'ETH' in Transfer&Mint action, but I am unable to finish creating Proposal, is this perhaps expected behavior on localhost?

newtoken

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 534bfc6

😎 Browse the preview: https://bafybeib5ufsxgwlqyleb6uzagra2whw6vjaxyqkzbwodlxkfjwa3cvoyam.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeigmo6e5wzwa36x5onven6fk6vmkpugdu5cit37ebfabvwbddtvzyy.ipfs.cf-ipfs.com

@Filipv95
Copy link
Contributor

@rossneilson I successfully created Proposal with 'Transfer&Mint' action and new ETH token!
Screenshot 2022-08-22 at 18 06 11

@mprasanjith mprasanjith merged commit 6ad53b6 into DXgovernance:develop Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action Builder enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native asset to asset lists
3 participants