You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following our refactor sessions everyone should have some idea of what we are doing in this initial refactor with the aim of splitting logic and styles for reuse in dxvote and guilds, improving code quality, testing and documentation.
The following definition of done should be used as a guide as you work through each task.
If there is anything you are unsure about or want to work collaboratively on then reach out in the chat and we can have more mobbing sessions.
Definition of done
Move components into new structure (wrappers folder)
Split up into multiple components in same file
Add new components to their own component folder
Define types in types/common for Components
Completely remove styles from wrappers and logic from components
Ensure absolute imports
Add i18n
Use the new wrapper as an import to replace old-components and test it works as expected and the same as current v1.1-beta branch
Unit test
For unit testing since we are aiming for no business logic inside the components we should be fine to do simple snapshot tests like in this PR. If you need to mock data fetching then probably you need to split things up more. For the wrappers we are also aiming not to need to test these as the bulk of logic should be in hooks which are also tested (I believe we have some examples of this coming soon)
Storybook
Remove old-components folders
The text was updated successfully, but these errors were encountered:
Following our refactor sessions everyone should have some idea of what we are doing in this initial refactor with the aim of splitting logic and styles for reuse in dxvote and guilds, improving code quality, testing and documentation.
The following definition of done should be used as a guide as you work through each task.
If there is anything you are unsure about or want to work collaboratively on then reach out in the chat and we can have more mobbing sessions.
Definition of done
For unit testing since we are aiming for no business logic inside the components we should be fine to do simple snapshot tests like in this PR. If you need to mock data fetching then probably you need to split things up more. For the wrappers we are also aiming not to need to test these as the bulk of logic should be in hooks which are also tested (I believe we have some examples of this coming soon)
The text was updated successfully, but these errors were encountered: