Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmer Enchantment Needs Help #171

Closed
Haxley opened this issue Jun 21, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@Haxley
Copy link
Contributor

commented Jun 21, 2018

Please make sure your issue complies with these guidelines:

    • Server Software must be the official PMMP w/o vanilla patching plugins (i.e. TeaSpoon)
    • Issue must have not been reported previously
    • Make sure you are on the latest version of PMMP & PiggyCustomEnchants
    • Have a detailed title, like "CustomEnchants::getName() must be..."
    • If possible, provide crashdumps/errors related to the issue.

General

Crops that use their harvested item as the seed don't play well with the farmer enchantment. You can hold down farmer hoe on a carrot or potato crop and it will essentially just dupe the item. Crops that require seeds to grow, I.e. beetroot or wheat, are not necessarily effected by this. Holding farmer hoe on these crops will mass produce their seeds, but not the end-crop. This is all to say, farmer hoe only needs a one-block-sized farm for carrots & potatoes for maximum harvesting rate.

Version:

  • PiggyCustomEnchants: 1.1.3
  • PMMP: 1001

Steps to Reproduce the Issue

  1. Plant potato or carrot
  2. Hold farmer hoe on it
  3. Observe infinite potatoes/carrots being created

Extra Information

Suggestion is to only allow farmer enchant to replant the crop if the seed exists in your inventory, then remove the seed from the inventory once planted.

@DaPigGuy

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2018

This is not an issue. When someone breaks the potato, they get the one potato, and place it back, resulting in no gain, unless the crop has been grown.

@DaPigGuy DaPigGuy closed this Jun 21, 2018

@Haxley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

I think what your saying might happen if you stand directly on top of the crop, but not if you stand anywhere else. Please watch this video. In a matter of 15 seconds I was able to turn 1 potato into 20. https://cl.ly/2q453U3Y2w0Q

@DaPigGuy

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2018

You're using Fortune.

@Haxley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

I can confirm it happens with or without fortune. Would you like another video?

@DaPigGuy

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2018

Can't reproduce this issue whatsoever

@DaPigGuy

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2018

Oh. I have reproduced the issue.

@DaPigGuy

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2018

It will only work if you destroy a crop with a Farmer hoe without the crop in your inventory.

@DaPigGuy DaPigGuy reopened this Jun 21, 2018

@Haxley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

@Haxley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

Oh nice

@DaPigGuy DaPigGuy closed this in 24dbf6d Jun 21, 2018

@Aericio Aericio added the fixed/done label Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.