New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml-string remapping from quoted strings to native strings. #36

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@t4im
Contributor

t4im commented Nov 29, 2018

Besides being less verbose than depending on a custom tag for native strings (i.e. python strings, which are directly used in the templates),
it should fix an issue where referenced yaml blocks lead to overquoted strings in the templates like """"""""""SomeConstant""""""""""

Quoted strings for c++ string literals can be set as quotes within forced yaml strings i.e. '"literal"' or "\"literal\""

In a similar way chars can now be specified, just with different quotes on the inside: "'c'" or '\'c\''

I left the custom yaml loader in place in case we want to add other tags in the future.

Fix yaml-string remapping from quoted strings to native strings.
Besides being less verbose than depending on a custom tag for native strings,
it should fix an issue where referenced yaml blocks lead to overquoted strings in the templates like """"""""""SomeConstant""""""""""

Quoted strings for c++ string literals can be set as quotes within forced yaml strings i.e. '"literal"' or "\"literal\""
In a similar way chars could be specified, just with different quotes on the inside: "'c'" or '\'c\''
@Kangz

Kangz approved these changes Nov 29, 2018

@t4im t4im merged commit 80d36f2 into DaemonEngine:master Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment