New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial void effect on station15 tree model #119

Open
illwieckz opened this Issue Aug 28, 2018 · 4 comments

Comments

2 participants
@illwieckz
Copy link
Member

illwieckz commented Aug 28, 2018

See that weird void effect at the tip of the conifer branch:

incorrect

It must look like this:

correct

Note that the bug seems to occur on the collision with the plant leaf model. For information, there is also an alphagen brush in source map at this place:

netradiant

This bug looks somewhat related to that bug noticed in wolf:et map (at least for the tree):
Unvanquished/Unvanquished#799 (comment)

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Aug 28, 2018

@gimhael the somwhat fix for #118 also somewhat fixes this (the texture is right but lighting is wrong):

incorrect

somewhat correct

It also somewhat fixes Unvanquished/Unvanquished#799 bug at least for the tree part:

incorrect

somewhat correct

But that variant of the bug is still remaining:

incorrect

It was noticed in Unvanquished/Unvanquished#799 (see comment) that the wolf:et bug was introduced in 6cb4dcc but the source tree was buildable starting with commit 97cbb46 (those are translated commit ids in Daemon repository after engine split, see the other thread for commits ids on Unvanquished repository).

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Aug 28, 2018

For testing purpose a snapshot of for-0.51.0 assets (including station15 map) can be fetched this way:

wget -O- http://gg.illwieckz.net/dl/unvanquished/dev/UnvanquishedAssets.get | xargs wget
@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Aug 28, 2018

For testing purpose one can load wolf:et's railgun map this way:

  • Download official etlegacy assets from an official mirror (you can use pimi):
pimi.sh etmain
  • Add some compatibility layer (no legal issue, it's just doing symlinks, downloading empty dpks containing DEPS file only and downloading a spawn layout so the game does not end at startup):
mkdir -p ~/.local/share/unvanquished/pkg/etmain
mkdir -p ~/.local/share/unvanquished/game/layouts/railgun
ln -s ~/.etlegacy/etmain/pak0.pk3 ~/.local/share/unvanquished/pkg/etmain/pak0_0.dpk
ln -s ~/.etlegacy/etmain/pak1.pk3 ~/.local/share/unvanquished/pkg/etmain/pak1_0.dpk
ln -s ~/.etlegacy/etmain/pak2.pk3 ~/.local/share/unvanquished/pkg/etmain/pak2_0.dpk
wget -O ~/.local/share/unvanquished/pkg/etmain/res-etmain_0.dpk http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/pkg/etmain/res-etmain_0.pk3
wget -O ~/.local/share/unvanquished/pkg/etmain/map-railgun_0.dpk http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/pkg/etmain/map-railgun_0.pk3
wget -O ~/.local/share/unvanquished/game/layouts/railgun/spawn.dat http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/game/layouts/railgun/spawn.dat
  • Load the railgun map with the cheat to never end on missing spawn:
daemon -pakpath ~/.local/share/unvanquished/pkg/etmain/ +set g_neverend 1 +devmap railgun
  • Load the railgun map with the spawn layout:
daemon -pakpath ~/.local/share/unvanquished/pkg/etmain/ +devmap railgun spawn

@illwieckz illwieckz added this to To do in Unvanquished Oct 24, 2018

@t4im t4im added the Renderer label Nov 24, 2018

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Dec 14, 2018

note that the unattended side-effect "somewhat fix" previously talked about is not there anymore, bug was brought back when lighting was fixed, i.e the complete fix for the other bug left this one unmodified despite some work in progress had some effect on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment