Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glsl ifdef generator does not set define anytime #190

Open
illwieckz opened this Issue Mar 24, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@illwieckz
Copy link
Member

commented Mar 24, 2019

See #189 for a branch that reproduces the bug (you need Xonotic assets since Unvanquished ones run the code used when the define is not defined).

It looks like the define is not defined any time as while I move in map, the wrong code is sometime run instead of the expected one:

glsl ifdef

glsl ifdef

The bug is on the wall texture, not on the blooming reactor.

I understand nothing from the define generator code and I need help to fix it, or someone who understands it to fix it himself.

@illwieckz illwieckz changed the title glsl ifdef code does not set define anytime glsl ifdef generator does not set define anytime Mar 24, 2019

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

If I understand it right, the code computes a program index for each shader variation, so it can switch to one of those program per texture within one frame. I guess the issue is that the index computation gets some collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.