Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port virtual machine from NaCl to WebAssembly aka Wasm #227

Open
illwieckz opened this issue Nov 23, 2019 · 7 comments
Open

port virtual machine from NaCl to WebAssembly aka Wasm #227

illwieckz opened this issue Nov 23, 2019 · 7 comments

Comments

@illwieckz

This comment has been minimized.

Copy link
Member Author

@illwieckz illwieckz commented Nov 23, 2019

There is also a list of Wasm runtimes there: https://gitlab.com/xonotic/xonotic/issues/244#sandboxing

@illwieckz

This comment has been minimized.

Copy link
Member Author

@illwieckz illwieckz commented Nov 23, 2019

@Kangz do you have any opinion on existing Wasm runtimes?

@illwieckz

This comment has been minimized.

Copy link
Member Author

@illwieckz illwieckz commented Nov 24, 2019

Dropping NaCl would also help us to drop the external deps download.

@DolceTriade

This comment has been minimized.

Copy link
Contributor

@DolceTriade DolceTriade commented Nov 28, 2019

It would change the external_deps download. The external_deps download downloads the NaCl toolchain and some common NaCl libraries. This would be instead changed to the wasm toolchain and the same libraries, but wasm...

@illwieckz

This comment has been minimized.

Copy link
Member Author

@illwieckz illwieckz commented Nov 28, 2019

I secretly hope we would be able one day to get rid of an SDK download at build time, to rely on system tools or git submodules instead.

To me that external_deps download is part of the NaCl issue.

@DolceTriade

This comment has been minimized.

Copy link
Contributor

@DolceTriade DolceTriade commented Nov 28, 2019

I mean, you can repackage the SDK as a submodule instead. I prefer having the build system "magically" ensure you have all the requisite dependencies.

@illwieckz

This comment has been minimized.

Copy link
Member Author

@illwieckz illwieckz commented Nov 29, 2019

I would prefer a submodule than what we currently do as I agree with people being concerned by random download done at CMake time. That said, it's better to invest time in Wasm and get rid of NaCl in the process than making NaCl a submodule.

Does using NaCl as a submodule would help Unvanquished to run outside of i386/amd64 or it's not only a limitation of our toolchain but a limitation of NaCl itself?

@illwieckz illwieckz changed the title port virtual machine from NaCl to WebAssembly aka Wasm feature-request: port virtual machine from NaCl to WebAssembly aka Wasm Dec 10, 2019
@illwieckz illwieckz changed the title feature-request: port virtual machine from NaCl to WebAssembly aka Wasm port virtual machine from NaCl to WebAssembly aka Wasm Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.