Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stack protector in external_deps #988

Open
slipher opened this issue Dec 8, 2023 · 0 comments
Open

Enable stack protector in external_deps #988

slipher opened this issue Dec 8, 2023 · 0 comments

Comments

@slipher
Copy link
Member

slipher commented Dec 8, 2023

Set the -fstack-protector-whatever flag in external_deps/build.sh.

Annoyingly, when building with MinGW this will cause an extra DLL dependency. At least this DLL is (so I believe) flavor-independent, so it shouldn't be too bad. We already ship the libssp DLL with our Windows release builds.

I don't think there is any effect on dynamic dependencies for non-Windows platforms but I should double-check.

I think I will skip it for MSVC packages because I'm not 100% sure it would work correctly and also having to ship the libssp DLL with the MSVC binaries would be annoying. Plus those aren't used in releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant