New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty: Do not use nonblocking stdin #146

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@DolceTriade
Copy link
Contributor

DolceTriade commented Dec 25, 2018

This is buggy because if the engine is launched from a shell,
stdin will be shared and if anything on the shell (like gdb)
changes the stdin status, then unvanquished will also block.
Instead use select to determine if there is input ready to
be read. I didn't not notice any performance impact from this
change.

tty: Do not use nonblocking stdin
This is buggy because if the engine is launched from a shell,
stdin will be shared and if anything on the shell (like gdb)
changes the stdin status, then unvanquished will also block.
Instead use select to determine if there is input ready to
be read. I didn't not notice any performance impact from this
change.

@DolceTriade DolceTriade force-pushed the nonblock branch from cd08e62 to ba163b7 Dec 25, 2018

@DolceTriade DolceTriade changed the title tty: Replace read() with recv(MSG_DONTWAIT) for stdin. tty: Do not use nonblocking stdin Dec 25, 2018

@DolceTriade

This comment has been minimized.

Copy link
Contributor

DolceTriade commented Dec 25, 2018

Pretty sure this is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment