New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing FS::InternalLoadPak to only get timestamp for .dpk files. #152

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@JacksonTech
Copy link

JacksonTech commented Jan 6, 2019

No longer attempts to get timestamp for directories.

Fixes bug where my_stat (_wstat64i) was failing on Windows when
trailing slash was present.

In the future, trim trailing slash should work on all platforms.

Not sure if this has unintended consequences (are timestamps really useless for dpkdirs?). Please review.

Cody Jackson
Fixing FS::InternalLoadPak to only get timestamp for .dpk files.
No longer attempts to get timestamp for directories.

Fixes bug where my_stat (_wstat64i) was failing on Windows when
trailing slash was present.

In the future, trim trailing slash should work on all platforms.
Show resolved Hide resolved src/common/FileSystem.cpp Outdated
@Kangz

Kangz approved these changes Jan 7, 2019

Copy link
Contributor

Kangz left a comment

LGTM

@illwieckz illwieckz merged commit 66a062e into DaemonEngine:master Jan 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illwieckz illwieckz added this to the unv/for-0.52.0 milestone Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment