New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly non-functional changes #156

Merged
merged 5 commits into from Feb 9, 2019

Conversation

Projects
None yet
3 participants
@slipher
Copy link
Contributor

slipher commented Feb 4, 2019

No description provided.

slipher added some commits Jan 29, 2019

Replace 'long' with other integral types in various places
It's no good to use long since it has different meaning per OS.
Split FS_ComparePaks into 2 functions
One of them deletes paks with a mismatched checksum. The other returns
the list paks that need to be downloaded (encoded into a string for no
reason). Also raise an error if a file can't be deleted.
@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Feb 4, 2019

Quote from IRC:

<illwieckz> I wonder for what the MinimumDelay class was useful for. is it a kind of cron?
or does it just prevent to not do too early something that may be already done recently?
<perturbed`> the latter, i made it for preventing a log message from being printed too
many times, but then i made spammy log messages be automatically silinced so it was
no longer needed
<illwieckz> oh I see, great then
<illwieckz> so the com_missingFiles cvar was not used at all?
<perturbed`> no, and it would not be usable at all since there was no separator between
the names
<illwieckz> I see

I'm OK with what the PR claims to do but I don't have the brain ready enough to proofread the code at this time. So it LGTM if a second pair of eyes looks at it.

@slipher slipher merged commit be89425 into DaemonEngine:master Feb 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:aoeu branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment