From 725299d5e2d3ec86550412a305cf6e571c76a017 Mon Sep 17 00:00:00 2001 From: slipher Date: Thu, 27 Mar 2025 09:41:32 -0500 Subject: [PATCH 1/2] external_deps: print error when curl not found Also allow --help without curl. --- external_deps/build.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/external_deps/build.sh b/external_deps/build.sh index b78a9f5290..8bdcb0fa50 100755 --- a/external_deps/build.sh +++ b/external_deps/build.sh @@ -6,11 +6,6 @@ set -u -e -o pipefail SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)" WORK_DIR="${PWD}" -# Do not reuse self-built curl from external_deps custom PATH -# to download source archives or we would get errors like: -# curl: (1) Protocol "https" not supported or disabled in libcurl -CURL="$(command -v curl)" - # This should match the DEPS_VERSION in CMakeLists.txt. # This is mostly to ensure the path the files end up at if you build deps yourself # are the same as the ones when extracting from the downloaded packages. @@ -1295,6 +1290,11 @@ if [ "${#}" -lt "2" ]; then errorHelp fi +# Do not reuse self-built curl from external_deps custom PATH +# to download source archives or we would get errors like: +# curl: (1) Protocol "https" not supported or disabled in libcurl +CURL="$(command -v curl)" || log ERROR "Command 'curl' not found" + # Enable parallel build export MAKEFLAGS="-j`nproc 2> /dev/null || sysctl -n hw.ncpu 2> /dev/null || echo 1`" export SCONSFLAGS="${MAKEFLAGS}" From 2aedcd090a5635b25950170dc373a0860e144099 Mon Sep 17 00:00:00 2001 From: slipher Date: Thu, 29 May 2025 19:03:10 -0500 Subject: [PATCH 2/2] external_deps/build.sh logging nit 'log status' -> 'log STATUS' (spot missed in 528fc2266ec663db90feea87dc2cda6409a0ca71) --- external_deps/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external_deps/build.sh b/external_deps/build.sh index 8bdcb0fa50..43efa90132 100755 --- a/external_deps/build.sh +++ b/external_deps/build.sh @@ -130,7 +130,7 @@ download() { log ERROR "No more mirror to download ${tarball_file} from" fi local download_url="${1}"; shift - log status "Downloading ${download_url}" + log STATUS "Downloading ${download_url}" if ! "${CURL}" -R -L --fail -o "${tarball_file}" "${download_url}" then log WARNING "Failed to download ${download_url}"