Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export game surfaceflags to CustomSurfaceFlags.h, fix #107 #177

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@illwieckz
Copy link
Member

illwieckz commented Mar 4, 2019

This is an easy way to fix #107

I just noticed that those surfaceflags either add new values, either replace existing ones, like game's CONTENTS_NOBUILD sharing the 0x00004000 value with engine's CONTENTS_MOVER.

So in any way, games just want to add values or to override one to do ugly tricks like our game does.

If one day games want a more elaborated behavior, it would be still time to elaborate more.

See also Unvanquished/Unvanquished#1107 for related PR on the game side.

@illwieckz illwieckz added this to To do in Standalone via automation Mar 5, 2019

@slipher

This comment has been minimized.

Copy link
Contributor

slipher commented Mar 5, 2019

LGTM

@illwieckz illwieckz force-pushed the illwieckz:customsurfaceflags branch from c70945d to 0ac4da9 Mar 10, 2019

@illwieckz illwieckz added the cleanup label Mar 13, 2019

@illwieckz illwieckz added this to To do in Unvanquished via automation Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.