Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R_FindCubeImage: avoid the boring “Failed to open” on skybox format try #178

Merged
merged 6 commits into from Mar 6, 2019

Conversation

2 participants
@illwieckz
Copy link
Member

illwieckz commented Mar 5, 2019

This is to avoid those boring, false-positive debug messages:

Debug: Failed to open 'env/shared_vega_src/sky' for reading: No such file or directory
Debug: Failed to open 'env/shared_vega_src/sky' for reading: No such file or directory

Note that the R_FindImageLoader code (first two commits) is the one I first pushed in #159.
If first worked on R_FindImageLoader for the need of the removal of this debug message, but working on Xonotic stuff was more exciting. 😛

This is better to merge this first, as the image commits will be together, and then the dpMaterial PR would just be 1 commit.

@illwieckz illwieckz force-pushed the illwieckz:skywarning branch from 75484a1 to 0c8b7ae Mar 5, 2019

@slipher
Copy link
Contributor

slipher left a comment

Looks solid, just some style issues.

Show resolved Hide resolved src/engine/renderer/tr_image.cpp Outdated
Show resolved Hide resolved src/engine/renderer/tr_image.cpp Outdated
Show resolved Hide resolved src/engine/renderer/tr_local.h Outdated
Show resolved Hide resolved src/engine/renderer/tr_image.cpp Outdated
Show resolved Hide resolved src/engine/renderer/tr_image.cpp Outdated

@illwieckz illwieckz force-pushed the illwieckz:skywarning branch 2 times, most recently from ec2bf88 to 728eb18 Mar 6, 2019

@illwieckz illwieckz force-pushed the illwieckz:skywarning branch from 728eb18 to 9436274 Mar 6, 2019

@illwieckz illwieckz force-pushed the illwieckz:skywarning branch from 5d3f939 to f71cba5 Mar 6, 2019

@illwieckz illwieckz merged commit f71cba5 into DaemonEngine:master Mar 6, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illwieckz illwieckz added this to To do in Unvanquished via automation Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.