Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console font resizing #196

Merged
merged 7 commits into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@slipher
Copy link
Contributor

commented Mar 31, 2019

+ misc tiny changes

Fixes #162.

@@ -102,7 +102,7 @@ AudioData LoadSoundCodec(std::string filename)
return AudioData();
}

audioLogs.Warn("Sound file %s not found.", filename);
audioLogs.Notice("Sound file '%s' not found.", filename);

This comment has been minimized.

Copy link
@illwieckz

illwieckz Mar 31, 2019

Member

I would not be surprised is the given warning is there to tell us some code is trying to load an optional file without checking if it exists first, so silencing the warning would not be the right fix as the warning must be there when the file is not optional.

This comment has been minimized.

Copy link
@illwieckz

illwieckz Mar 31, 2019

Member

i.e. this is probably better to take care of that in another PR, I was planning to investigate on this but I don't own this, but I know there is some code trying to load optional file the required way in other places (like the model code), it may be a game issue, not an engine one.

This comment has been minimized.

Copy link
@illwieckz

illwieckz Mar 31, 2019

Member

see 7774ff8 that is expected, the code trying to use a sound file that does not exist has to be fixed instead, so can you remove this commit? If you want I may look myself for why the code is trying to load files that does not exist, I'll was going to do it one day in any way.

This comment has been minimized.

Copy link
@slipher

slipher Mar 31, 2019

Author Contributor

Yeah I know, I asked for it :) Didn't know it would lead to warning spam though. I've filed Unvanquished/Unvanquished#1110 so the issue will not be buried, but in the meantime before anyone gets to looking at it, let's silence the warning.

@@ -1093,8 +1093,6 @@ static inline void halfToFloat( const f16vec4_t in, vec4_t out )

uint32_t stateBits; // GLS_xxxx mask

bool heightMapInNormalMap;

This comment has been minimized.

Copy link
@illwieckz

illwieckz Mar 31, 2019

Member

my bed!

@@ -1906,8 +1906,6 @@ and determine if we need to download them
*/
void CL_InitDownloads()
{
char missingfiles[ 1024 ];

This comment has been minimized.

Copy link
@illwieckz

@slipher slipher merged commit 2b5745b into DaemonEngine:master Apr 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:font branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.