Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary work for VM restarts #203

Merged
merged 8 commits into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@slipher
Copy link
Member

commented Apr 21, 2019

This is some stuff that has come up while working on #201.

slipher added some commits Apr 8, 2019

Move hunk allocation functions to their own file
Also rename Com_InitHunkMemory to Hunk_Init
Slight reorganization of Com_Init
It now contains only calls to functions that need to be called by all
application types, and are only called once in the program lifetime.
Fix incorrect implementation of server 'watchdog'
It is supposed to act if the server has no map for <watchdogThreshold>
seconds, but the actual implementation was to act if the server has no
map at any two points in time at least <watchdogThreshold> seconds
apart.
Handle exceptions during VM shutdowns better
For each vm there was one try/catch handling DropErr which sent the
shutdown message and called Free(). But either one of these can throw
DropErr and Free should still be called, so there should be two
try/catch blocks.
@DolceTriade

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Very good clean up

@slipher slipher merged commit 8d2fbd6 into DaemonEngine:master Apr 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:initialize-pre branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.