Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CVAR_SHADER with CVAR_LATCH #204

Merged
merged 1 commit into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@slipher
Copy link
Member

commented Apr 22, 2019

No description provided.

Replace CVAR_SHADER with CVAR_LATCH
Changing a cvar with CVAR_SHADER was supposed to set the
r_recompileShaders cvar which would somehow trigger shader
recompilation, but the implementation was deleted, so replace it with
CVAR_LATCH.
@illwieckz

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

looks good to me, by the way it's useful to remind that CVAR_LATCH is only supported in legacy cvars like the renderer ones at this time:
https://github.com/DaemonEngine/Daemon/blob/master/src/engine/framework/CvarSystem.h#L101

@slipher slipher merged commit c4772b5 into DaemonEngine:master Apr 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:cvarshader branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.